Page MenuHomeFreeBSD
Differential D18246

sfxge(4): fix build because of no declaration
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 9, 3:01 PM
Unknown Object (File)
Thu, Nov 20, 8:34 PM
Unknown Object (File)
Thu, Nov 20, 8:31 PM
Unknown Object (File)
Thu, Nov 20, 8:25 PM
Unknown Object (File)
Thu, Nov 20, 8:11 PM
Unknown Object (File)
Thu, Nov 20, 5:44 AM
Unknown Object (File)
Wed, Nov 19, 3:30 PM
Unknown Object (File)
Wed, Nov 19, 7:29 AM
View All 78 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342513: MFC r341215
rS342442: MFC r341215
rS342335: MFC r341215
rS341215: sfxge(4): fix build because of no declaration
Summary

Functions declared in mcdi_mon.h are implemented in mcdi_mon.c.
The build fails if compiler options require declaration before definition.

Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21104
Build 20467: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:51 AM
Harbormaster completed remote builds in B21104: Diff 50845.Nov 21 2018, 11:52 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2018, 6:47 AM
Closed by commit rS341215: sfxge(4): fix build because of no declaration (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2018, 6:47 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
1 line

Diff 50845

View Options

sys/dev/sfxge/common/mcdi_mon.c

Loading...