sfxge(4): fix build because of no declaration
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:51 AM.

Tags

None

Referenced Files

	F164961003: D18246.diff
	Wed, Aug 5, 3:24 AM

	F164952308: D18246.diff
	Wed, Aug 5, 2:32 AM

	Unknown Object (File)
	Tue, Jul 28, 8:23 PM

	Unknown Object (File)
	Jun 19 2026, 6:30 AM

	Unknown Object (File)
	May 1 2026, 11:24 AM

	Unknown Object (File)
	Apr 24 2026, 3:25 PM

	Unknown Object (File)
	Apr 24 2026, 2:21 PM

	Unknown Object (File)
	Apr 21 2026, 6:46 AM

View All Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS342513: MFC r341215
rS342442: MFC r341215
rS342335: MFC r341215
rS341215: sfxge(4): fix build because of no declaration

Summary

Functions declared in mcdi_mon.h are implemented in mcdi_mon.c.
The build fails if compiler options require declaration before definition.

Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:51 AM

Harbormaster completed remote builds in B21104: Diff 50845.Nov 21 2018, 11:52 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2018, 6:47 AM

Closed by commit rS341215: sfxge(4): fix build because of no declaration (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 29 2018, 6:47 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

mcdi_mon.c

1 line

Diff 51343

View Options

head/sys/dev/sfxge/common/mcdi_mon.c

sfxge(4): fix build because of no declarationClosedPublicActions