Page MenuHomeFreeBSD
Differential D1819

libdwarf: Handle .rel relocations
ClosedPublic
Actions

Authored by emaste on Feb 10 2015, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 26, 6:33 AM
Unknown Object (File)
Sat, Oct 25, 2:07 PM
Unknown Object (File)
Sat, Oct 25, 2:06 PM
Unknown Object (File)
Sat, Oct 25, 2:06 PM
Unknown Object (File)
Sat, Oct 25, 2:06 PM
Unknown Object (File)
Sat, Oct 25, 5:23 AM
Unknown Object (File)
Fri, Oct 24, 1:58 AM
Unknown Object (File)
Thu, Oct 23, 12:31 PM
View All Files
Subscribers
freebsd-toolchain-list
rpaulo

Details

Reviewers
rpaulo
imp
gnn
br
Commits
rS278611: libdwarf: Handle .rel relocations
Summary

Some architectures have .rel relocations for debug data, so handle it in addition to .rela.

Issue discovered from ctfconvert on un-linked ARM object files.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 3722.Feb 10 2015, 8:50 PM
emaste retitled this revision from to libdwarf: Handle .rel relocations.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: gnn.
emaste added a subscriber: Unknown Object (MLST).
rpaulo accepted this revision.Feb 11 2015, 7:19 PM
rpaulo added a reviewer: rpaulo.
rpaulo added a subscriber: rpaulo.

Reviewed.

This revision is now accepted and ready to land.Feb 11 2015, 7:19 PM
emaste added a reviewer: br.Feb 11 2015, 7:25 PM
emaste updated this revision to Diff 3741.Feb 11 2015, 8:00 PM
emaste edited edge metadata.

Refactor common parts of .rel and .rela handling, based on feedback about non-obvious size==0 return from _dwarf_get_reloc_size

This revision now requires review to proceed.Feb 11 2015, 8:00 PM
gnn accepted this revision.Feb 11 2015, 10:40 PM
gnn edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2015, 10:40 PM
imp accepted this revision.Feb 11 2015, 11:33 PM
imp added a reviewer: imp.
emaste closed this revision.Feb 12 2015, 2:09 AM
emaste updated this revision to Diff 3742.

Closed by commit rS278611 (authored by @emaste).

Revision Contents
Changeset List

PathSize
head/
contrib/
elftoolchain/
libdwarf/
2 lines
4 lines
4 lines
2 lines
71 lines

Diff 3742

View Options

head/contrib/elftoolchain/libdwarf/_libdwarf.h

Loading...
View Options

head/contrib/elftoolchain/libdwarf/dwarf_reloc.c

Loading...
View Options

head/contrib/elftoolchain/libdwarf/dwarf_set_reloc_application.3

Loading...
View Options

head/contrib/elftoolchain/libdwarf/libdwarf.c

Loading...
View Options

head/contrib/elftoolchain/libdwarf/libdwarf_elf_init.c

Loading...