Page MenuHomeFreeBSD
Differential D18179

sfxge(4): resolve code analysis warnings
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:39 AM.
Tags
None
Referenced Files
F108619474: D18179.diff
Sun, Jan 26, 10:35 PM
Unknown Object (File)
Fri, Jan 10, 7:08 AM
Unknown Object (File)
Fri, Jan 10, 7:02 AM
Unknown Object (File)
Oct 17 2024, 6:37 PM
Unknown Object (File)
Oct 2 2024, 4:05 PM
Unknown Object (File)
Sep 30 2024, 11:31 PM
Unknown Object (File)
Sep 22 2024, 4:50 AM
Unknown Object (File)
Sep 8 2024, 8:07 PM
View All 34 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341065: sfxge(4): resolve code analysis warnings
Summary

Minimal changes adding buffer size checks and simplifying checksum
processing.

Submitted by: Richard Houldsworth <rhouldsworth at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21037
Build 20400: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:39 AM
Harbormaster completed remote builds in B21037: Diff 50778.Nov 21 2018, 11:39 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2018, 2:16 PM
Closed by commit rS341065: sfxge(4): resolve code analysis warnings (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 27 2018, 2:16 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
67 lines

Diff 50778

View Options

sys/dev/sfxge/common/efx_bootcfg.c

Loading...