Page MenuHomeFreeBSD
Differential D18021

Improve KASSERTs in rack.c
ClosedPublic
Actions

Authored by tuexen on Nov 17 2018, 8:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 4:39 PM
Unknown Object (File)
Tue, Jan 14, 3:54 PM
Unknown Object (File)
Wed, Jan 1, 7:45 PM
Unknown Object (File)
Dec 8 2024, 3:59 PM
Unknown Object (File)
Dec 7 2024, 9:39 PM
Unknown Object (File)
Nov 16 2024, 10:24 AM
Unknown Object (File)
Oct 26 2024, 12:00 AM
Unknown Object (File)
Oct 25 2024, 11:59 PM
View All 66 Files
Subscribers
imp

Details

Reviewers
rrs
jason_eggnet.com
Group Reviewers
transport
Commits
rS341497: MFC r340738:
rS340738: Improve two KASSERTs in the TCP RACK stack.
Summary

PR229664 points out that two KASSERT checks will never be triggered, since an unsigned variable is tested for being negative.
This patch fixes the two tests and uses the same pattern for a third test, which ensures the same condition. This is for consistency.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Nov 17 2018, 8:41 PM
Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptNov 17 2018, 8:41 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B20862: Diff 50536.Nov 17 2018, 8:41 PM
rrs accepted this revision.Nov 20 2018, 12:57 PM
This revision is now accepted and ready to land.Nov 20 2018, 12:57 PM
tuexen updated this revision to Diff 50732.Nov 21 2018, 11:30 AM

Use SEQ_LT instead of <= since sequence number arithmetic is used.

This revision now requires review to proceed.Nov 21 2018, 11:30 AM
Harbormaster completed remote builds in B20993: Diff 50732.Nov 21 2018, 11:30 AM
tuexen updated this revision to Diff 50736.Nov 21 2018, 11:32 AM

Use SEQ_LEQ instead of <= since sequence number arithmetic needs to be used.

Harbormaster completed remote builds in B20996: Diff 50736.Nov 21 2018, 11:32 AM
rrs accepted this revision.Nov 21 2018, 12:30 PM

Good catch Michael!!!

This revision is now accepted and ready to land.Nov 21 2018, 12:30 PM
Closed by commit rS340738: Improve two KASSERTs in the TCP RACK stack. (authored by tuexen). · Explain WhyNov 21 2018, 6:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
tcp_stacks/
22 lines

Diff 50899

View Options

head/sys/netinet/tcp_stacks/rack.c

Loading...