Paths

Table of Contentst

Differential D18021

Improve KASSERTs in rack.c
ClosedPublic
Actions

Authored by tuexen on Nov 17 2018, 8:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 20 2023, 5:59 AM

	Unknown Object (File)
	Dec 12 2023, 2:22 AM

	Unknown Object (File)
	Dec 11 2023, 3:51 AM

	Unknown Object (File)
	Nov 18 2023, 11:28 PM

	Unknown Object (File)
	Nov 18 2023, 9:16 PM

	Unknown Object (File)
	Nov 18 2023, 9:16 PM

	Unknown Object (File)
	Nov 18 2023, 8:46 PM

	Unknown Object (File)
	Nov 15 2023, 12:54 AM

View All 38 Files

Subscribers

Details

Reviewers

rrs
jason_eggnet.com

Group Reviewers

Commits

rS341497: MFC r340738:
rS340738: Improve two KASSERTs in the TCP RACK stack.

Summary

PR229664 points out that two KASSERT checks will never be triggered, since an unsigned variable is tested for being negative.
This patch fixes the two tests and uses the same pattern for a third test, which ensures the same condition. This is for consistency.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 20862

Event Timeline

tuexen created this revision.Nov 17 2018, 8:41 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptNov 17 2018, 8:41 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B20862: Diff 50536.Nov 17 2018, 8:41 PM

rrs accepted this revision.Nov 20 2018, 12:57 PM

This revision is now accepted and ready to land.Nov 20 2018, 12:57 PM

Use SEQ_LT instead of <= since sequence number arithmetic is used.

This revision now requires review to proceed.Nov 21 2018, 11:30 AM

Harbormaster completed remote builds in B20993: Diff 50732.Nov 21 2018, 11:30 AM

Use SEQ_LEQ instead of <= since sequence number arithmetic needs to be used.

Harbormaster completed remote builds in B20996: Diff 50736.Nov 21 2018, 11:32 AM

Good catch Michael!!!

This revision is now accepted and ready to land.Nov 21 2018, 12:30 PM

Closed by commit rS340738: Improve two KASSERTs in the TCP RACK stack. (authored by tuexen). · Explain WhyNov 21 2018, 6:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

22 lines

Diff 50536

sys/netinet/tcp_stacks/rack.c

Loading...