Page MenuHomeFreeBSD
Differential D17949

Advertise a zero window when sending TCP RST segments via tcp_output()
ClosedPublic
Actions

Authored by tuexen on Nov 11 2018, 7:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 11:54 PM
Unknown Object (File)
Mon, Apr 21, 1:29 PM
Unknown Object (File)
Mon, Apr 21, 1:25 PM
Unknown Object (File)
Mon, Apr 21, 12:55 PM
Unknown Object (File)
Mon, Apr 21, 12:54 PM
Unknown Object (File)
Mon, Apr 21, 12:12 PM
Unknown Object (File)
Mon, Apr 21, 11:38 AM
Unknown Object (File)
Wed, Apr 16, 3:26 PM
View All 91 Files
Subscribers
imp

Details

Reviewers
rrs
jason_eggnet.com
lstewart
jtl
Group Reviewers
transport
Commits
rS341498: MFC r340774:
rS340774: Ensure that TCP RST-segments announce consistently a receiver window of
Summary

Set the advertised receiver window to zero when sending a TCP segment having the RST-bit set via the tcp_output() routine. This makes the behaviour consistent with sending RST segments via tcp_respond().

Test Plan

Run the tests from TCP test suite.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Nov 11 2018, 7:45 PM
Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptNov 11 2018, 7:45 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B20755: Diff 50289.Nov 11 2018, 7:45 PM
rrs accepted this revision.Nov 20 2018, 12:53 PM

This looks fine Michael :)

This revision is now accepted and ready to land.Nov 20 2018, 12:53 PM
Closed by commit rS340774: Ensure that TCP RST-segments announce consistently a receiver window of (authored by tuexen). · Explain WhyNov 22 2018, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
16 lines
tcp_stacks/
19 lines

Diff 50926

View Options

head/sys/netinet/tcp_output.c

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
yesterday=`date -v-1d "+%b %e "` yesterday=`date -v-1d "+%b %e "`
catmsgs() { catmsgs() {
find ${LOG} -name 'messages.*' -mtime -2 | find ${LOG} -name 'messages.*' -mtime -2 |
sort -t. -r -n -k 2,2 | sort -t. -r -n -k 2,2 |
while read f while read f
do do
case $f in zcat -f $f
*.gz) zcat -f $f;;
*.bz2) bzcat -f $f;;
*.xz) xzcat -f $f;;
*.zst) zstdcat -f $f;;
esac
done done
[ -f ${LOG}/messages ] && cat $LOG/messages [ -f ${LOG}/messages ] && cat $LOG/messages
} }
rc=0 rc=0
if check_yesno_period security_status_tcpwrap_enable if check_yesno_period security_status_tcpwrap_enable
then then
echo "" echo ""
echo "${host} refused connections:" echo "${host} refused connections:"
n=$(catmsgs | grep -i "^$yesterday.*refused connect" | n=$(catmsgs | grep -i "^$yesterday.*refused connect" |
tee /dev/stderr | wc -l) tee /dev/stderr | wc -l)
[ $n -gt 0 ] && rc=1 || rc=0 [ $n -gt 0 ] && rc=1 || rc=0
fi fi
exit $rc exit $rc
View Options

head/sys/netinet/tcp_stacks/rack.c

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
yesterday=`date -v-1d "+%b %e "` yesterday=`date -v-1d "+%b %e "`
catmsgs() { catmsgs() {
find ${LOG} -name 'messages.*' -mtime -2 | find ${LOG} -name 'messages.*' -mtime -2 |
sort -t. -r -n -k 2,2 | sort -t. -r -n -k 2,2 |
while read f while read f
do do
case $f in zcat -f $f
*.gz) zcat -f $f;;
*.bz2) bzcat -f $f;;
*.xz) xzcat -f $f;;
*.zst) zstdcat -f $f;;
esac
done done
[ -f ${LOG}/messages ] && cat $LOG/messages [ -f ${LOG}/messages ] && cat $LOG/messages
} }
rc=0 rc=0
if check_yesno_period security_status_tcpwrap_enable if check_yesno_period security_status_tcpwrap_enable
then then
echo "" echo ""
echo "${host} refused connections:" echo "${host} refused connections:"
n=$(catmsgs | grep -i "^$yesterday.*refused connect" | n=$(catmsgs | grep -i "^$yesterday.*refused connect" |
tee /dev/stderr | wc -l) tee /dev/stderr | wc -l)
[ $n -gt 0 ] && rc=1 || rc=0 [ $n -gt 0 ] && rc=1 || rc=0
fi fi
exit $rc exit $rc