Advertise a zero window when sending TCP RST segments via tcp_output()
ClosedPublic
Actions

Authored by tuexen on Nov 11 2018, 7:45 PM.

Tags

None

Referenced Files

	F82618407: D17949.id50289.diff
	Tue, Apr 30, 10:38 PM

	F82618404: D17949.id.diff
	Tue, Apr 30, 10:38 PM

	Unknown Object (File)
	Tue, Apr 30, 9:50 PM

	Unknown Object (File)
	Tue, Apr 30, 8:19 PM

	Unknown Object (File)
	Tue, Apr 30, 7:48 PM

	Unknown Object (File)
	Tue, Apr 23, 10:27 PM

	Unknown Object (File)
	Sat, Apr 20, 1:46 PM

	Unknown Object (File)
	Sat, Apr 20, 4:01 AM

View All 38 Files

Subscribers

imp

Details

Reviewers

rrs
jason_eggnet.com
lstewart
jtl

Group Reviewers

transport

Commits

rS341498: MFC r340774:
rS340774: Ensure that TCP RST-segments announce consistently a receiver window of

Summary

Set the advertised receiver window to zero when sending a TCP segment having the RST-bit set via the tcp_output() routine. This makes the behaviour consistent with sending RST segments via tcp_respond().

Test Plan

Run the tests from TCP test suite.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Nov 11 2018, 7:45 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptNov 11 2018, 7:45 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B20755: Diff 50289.Nov 11 2018, 7:45 PM

This looks fine Michael :)

This revision is now accepted and ready to land.Nov 20 2018, 12:53 PM

Closed by commit rS340774: Ensure that TCP RST-segments announce consistently a receiver window of (authored by tuexen). · Explain WhyNov 22 2018, 7:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_output.c

16 lines

tcp_stacks/

rack.c

19 lines

Diff 50926

View Options

head/sys/netinet/tcp_output.c