multimedia/clipgrab: add Qt5 support with FLAVOR
ClosedPublic
Actions

Authored by kikadf.01_gmail.com on Nov 8 2018, 3:50 PM.

Details

Reviewers: None
Commits: rP487078: multimedia/clipgrab: Update to 3.7.2

Summary

I add a PR to Bugzilla (231821). Would like to update version, and add Qt5 support to the officially Qt4 based clipgrab. Tobias Kortkamp suggested to make this with FLAVORS instead of the old-school slave ports.

So, I made this with FLAVORS, and works fine for me, but I need review.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kikadf.01_gmail.com created this revision.Nov 8 2018, 3:50 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptNov 8 2018, 3:50 PM

kikadf.01_gmail.com added a reviewer: portmgr.Nov 8 2018, 3:51 PM

kikadf.01_gmail.com removed a project: portmgr.

Moin moin

Given the looming deprecation and removal of Qt4 from the tree, I suggest thinking about just switching it to Qt5.

Mfg Tobias

Modified, remove FLAVORS, simply build Qt5 based clipgrab.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

flavors removed.

tcberner added inline comments.Nov 10 2018, 12:04 PM

multimedia/clipgrab/Makefile
8 ↗	(On Diff #50201)	^ you can get rid of the pkgname suffix, there is only one version, so no need to differentiate it further.
19 ↗	(On Diff #50201)	^ I would sort these like so USE_QT= core dbus network webkit xml \ buildtools_build