Page MenuHomeFreeBSD

Update xz to 5.2.0.
ClosedPublic

Authored by rpaulo on Feb 6 2015, 5:30 AM.
Tags
None
Referenced Files
F87705345: D1786.id3675.diff
Sun, Jul 7, 1:12 AM
Unknown Object (File)
Sat, Jul 6, 4:07 AM
Unknown Object (File)
Fri, Jul 5, 7:09 AM
Unknown Object (File)
Tue, Jul 2, 8:00 PM
Unknown Object (File)
Tue, Jul 2, 7:55 PM
Unknown Object (File)
Tue, Jul 2, 7:55 PM
Unknown Object (File)
Tue, Jul 2, 7:55 PM
Unknown Object (File)
Tue, Jul 2, 7:55 PM
Subscribers

Details

Summary

Update xz to 5.2.0.

This brings support for multi-threaded encoding/decoding.

Test Plan

Build and test it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rpaulo retitled this revision from to Update xz to 5.2.0..
rpaulo updated this object.
rpaulo edited the test plan for this revision. (Show Details)
rpaulo added reviewers: bapt, delphij.

Add lzma.h to ObsoleteFiles.inc.

Forgot to link liblzma with pthread.
Add a few more files to the build.

This would need an exp-run because everything statically linking to libarchive will now need to also be linked to pthread (pkg-static in particular will fail I'm almost sure of that)

pthread is not a lightweight change and may break some binaries at runtime as well.

src.libnames.mk should be modified as well

_DP_lzma= pthread
lib/liblzma/Makefile
167 โ†—(On Diff #3671)

This should be updated according to the liblzma.pc.in changes
so that -pthread is specified in Libs.private

if everything goes ok, do not MFC that before pthread support change from @kostikbel have been MFCed if not MFCed already

rpaulo edited edge metadata.

Fix /rescue.

Fix the prebuild libs dependency.

lib/liblzma/Makefile
167 โ†—(On Diff #3671)

Why wouldn't the library dependency work? liblzma depends on libpthread.

In D1786#7, @bapt wrote:

This would need an exp-run because everything statically linking to libarchive will now need to also be linked to pthread (pkg-static in particular will fail I'm almost sure of that)

Well, I asked for the exp-run, but pkg-static didn't break. pkg-static links with "-llzma" not with liblzma.a, so the dependency chain works. I just tested this myself.

bapt edited edge metadata.

That is great I have no more problems as long as the exp-run is ok then

This revision is now accepted and ready to land.Feb 7 2015, 9:57 PM
rpaulo updated this revision to Diff 3706.

Closed by commit rS278433 (authored by @rpaulo).