Page MenuHomeFreeBSD
Differential D17852

Use declared types for caddr_t arguments.
ClosedPublic
Actions

Authored by brooks on Nov 5 2018, 10:29 PM.
Tags
None
Referenced Files
F132312516: D17852.id50080.diff
Wed, Oct 15, 7:13 PM
F132312515: D17852.id.diff
Wed, Oct 15, 7:13 PM
F132312508: D17852.id50043.diff
Wed, Oct 15, 7:13 PM
Unknown Object (File)
Wed, Oct 15, 8:49 AM
Unknown Object (File)
Wed, Oct 8, 8:20 PM
Unknown Object (File)
Sun, Sep 28, 8:23 AM
Unknown Object (File)
Sun, Sep 28, 5:22 AM
Unknown Object (File)
Sat, Sep 27, 8:49 AM
View All 66 Files
Subscribers
imp

Details

Reviewers
kib
emaste
jhb
Commits
rS340200: Regen after r340199: Use declared types for caddr_t arguments.
rS340199: Use declared types for caddr_t arguments.
Summary

Leave ptrace(2) alone for the moment as it's defined to take a caddr_t.

Note: these changes don't compile without the followup regeneration
commit.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Nov 5 2018, 10:29 PM
Harbormaster completed remote builds in B20647: Diff 50043.Nov 5 2018, 10:29 PM
kib accepted this revision.Nov 6 2018, 2:05 AM
kib added inline comments.
sys/compat/linux/linux_socket.c
1577 ↗(On Diff #50043)

linux_to_bsd_sockaddr is an awful hack (not related to this change.) And deconst there demonstrates why it is also incorrect.

sys/kern/syscalls.master
339 ↗(On Diff #50043)

What about struct pstats::struct uprof::pr_base ?

This revision is now accepted and ready to land.Nov 6 2018, 2:05 AM
brooks marked 2 inline comments as done.Nov 6 2018, 4:08 PM
brooks added inline comments.
sys/compat/linux/linux_socket.c
1577 ↗(On Diff #50043)

Indeed. I created https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232920 to document its awfulness when I found it. The shortest path is probably to use copyout_map rather than doing this translation in place.

sys/kern/syscalls.master
339 ↗(On Diff #50043)

I went with char * because that's what the manpage and header say.

Closed by commit rS340199: Use declared types for caddr_t arguments. (authored by brooks). · Explain WhyNov 6 2018, 6:46 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 6 2018, 6:46 PM

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
freebsd32/
52 lines
linux/
9 lines
fs/
nfsclient/
3 lines
kern/
54 lines
12 lines
sys/
2 lines

Diff 50080

View Options

head/sys/compat/freebsd32/syscalls.master

Loading...
View Options

head/sys/compat/linux/linux_socket.c

Loading...
View Options

head/sys/fs/nfsclient/nfs_clvfsops.c

Loading...
View Options

head/sys/kern/syscalls.master

Loading...
View Options

head/sys/kern/uipc_syscalls.c

Loading...
View Options

head/sys/sys/syscallsubr.h

Loading...