Page MenuHomeFreeBSD

Use declared types for caddr_t arguments.
ClosedPublic

Authored by brooks on Nov 5 2018, 10:29 PM.
Tags
None
Referenced Files
F132312516: D17852.id50080.diff
Wed, Oct 15, 7:13 PM
F132312515: D17852.id.diff
Wed, Oct 15, 7:13 PM
F132312508: D17852.id50043.diff
Wed, Oct 15, 7:13 PM
F132268843: D17852.diff
Wed, Oct 15, 8:49 AM
Unknown Object (File)
Wed, Oct 8, 8:20 PM
Unknown Object (File)
Sun, Sep 28, 8:23 AM
Unknown Object (File)
Sun, Sep 28, 5:22 AM
Unknown Object (File)
Sat, Sep 27, 8:49 AM
Subscribers

Details

Summary

Leave ptrace(2) alone for the moment as it's defined to take a caddr_t.

Note: these changes don't compile without the followup regeneration
commit.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/compat/linux/linux_socket.c
1577 ↗(On Diff #50043)

linux_to_bsd_sockaddr is an awful hack (not related to this change.) And deconst there demonstrates why it is also incorrect.

sys/kern/syscalls.master
339 ↗(On Diff #50043)

What about struct pstats::struct uprof::pr_base ?

This revision is now accepted and ready to land.Nov 6 2018, 2:05 AM
brooks added inline comments.
sys/compat/linux/linux_socket.c
1577 ↗(On Diff #50043)

Indeed. I created https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232920 to document its awfulness when I found it. The shortest path is probably to use copyout_map rather than doing this translation in place.

sys/kern/syscalls.master
339 ↗(On Diff #50043)

I went with char * because that's what the manpage and header say.

This revision was automatically updated to reflect the committed changes.