Add const to input-only char * arguments.
ClosedPublic
Actions

Authored by brooks on Nov 1 2018, 11:39 PM.

Details

Reviewers

kib
emaste

Commits

rS340081: Regen after r340080: Add const to input-only char * arguments.
rS340080: Add const to input-only char * arguments.

Summary

These arguments are mostly paths handled by NAMEI*() macros which already
take const char * arguments.

This change improves the match between syscalls.master and the public
declerations of system calls.

Depends on D17805

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20591
Build 20012: arc lint + arc unit

Event Timeline

brooks created this revision.Nov 1 2018, 11:39 PM

Harbormaster completed remote builds in B20589: Diff 49916.Nov 1 2018, 11:39 PM

Rebase

Harbormaster completed remote builds in B20591: Diff 49919.Nov 1 2018, 11:53 PM

Are you going to reformat compat32/syscalls.master ?

This revision is now accepted and ready to land.Nov 2 2018, 12:28 AM

In D17812#380637, @kib wrote:

Are you going to reformat compat32/syscalls.master ?

I plan to replace it with improvements to makesyscalls.sh that will let us generate compat32 bits from kern/syscalls.master so I'm not very inclined to do the tedious work of reformatting it. I'm more than half done in CheriBSD where I'm working toward a freebsd64.

Closed by commit rS340080: Add const to input-only char * arguments. (authored by brooks). · Explain WhyNov 2 2018, 8:50 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 2 2018, 8:50 PM