SBI calls expect a pointer to a u_long rather than a pointer.
ClosedPublic
Actions

Authored by jhb on Oct 31 2018, 6:40 PM.

Tags

None

Referenced Files

	F110434150: D17781.diff
	Tue, Feb 18, 10:11 AM

	Unknown Object (File)
	Jan 12 2025, 8:25 AM

	Unknown Object (File)
	Dec 12 2024, 3:26 PM

	Unknown Object (File)
	Dec 8 2024, 6:13 PM

	Unknown Object (File)
	Nov 26 2024, 5:45 AM

	Unknown Object (File)
	Oct 1 2024, 12:46 PM

	Unknown Object (File)
	Sep 30 2024, 1:24 PM

	Unknown Object (File)
	Sep 22 2024, 8:18 AM

View All 35 Files

Subscribers

imp

Details

Reviewers

br
markj

Commits

rS340028: SBI calls expect a pointer to a u_long rather than a pointer.

Summary

This is just cosmetic.

A weirder issue is that the SBI doc claims the hart mask pointer should
be a physical address, not a virtual address. However, the implementation
in bbl seems to just dereference the address directly.

Test Plan

booted SMP under qemu

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 20540
Build 19965: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 31 2018, 6:40 PM

Harbormaster completed remote builds in B20540: Diff 49839.Oct 31 2018, 6:40 PM

markj accepted this revision.Oct 31 2018, 7:17 PM

This revision is now accepted and ready to land.Oct 31 2018, 7:17 PM

Closed by commit rS340028: SBI calls expect a pointer to a u_long rather than a pointer. (authored by jhb). · Explain WhyNov 1 2018, 10:15 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2018, 10:15 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

intr_machdep.c

4 lines

mp_machdep.c

2 lines

Diff 49839

View Options

sys/riscv/riscv/intr_machdep.c