SBI calls expect a pointer to a u_long rather than a pointer.
ClosedPublic
Actions

Authored by jhb on Oct 31 2018, 6:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 20, 10:34 PM

	Unknown Object (File)
	Sun, Sep 20, 4:12 PM

	Unknown Object (File)
	Fri, Sep 18, 10:54 PM

	Unknown Object (File)
	Fri, Sep 18, 10:39 PM

	Unknown Object (File)
	Fri, Sep 18, 7:17 PM

	Unknown Object (File)
	Fri, Sep 18, 3:29 PM

	Unknown Object (File)
	Thu, Sep 17, 5:52 PM

	Unknown Object (File)
	Wed, Sep 16, 9:30 PM

View All Files

Subscribers

imp

Details

Reviewers

br
markj

Commits

rS340028: SBI calls expect a pointer to a u_long rather than a pointer.

Summary

This is just cosmetic.

A weirder issue is that the SBI doc claims the hart mask pointer should
be a physical address, not a virtual address. However, the implementation
in bbl seems to just dereference the address directly.

Test Plan

booted SMP under qemu

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 31 2018, 6:40 PM

Harbormaster completed remote builds in B20540: Diff 49839.Oct 31 2018, 6:40 PM

markj accepted this revision.Oct 31 2018, 7:17 PM

This revision is now accepted and ready to land.Oct 31 2018, 7:17 PM

Closed by commit rS340028: SBI calls expect a pointer to a u_long rather than a pointer. (authored by jhb). · Explain WhyNov 1 2018, 10:15 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2018, 10:15 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

intr_machdep.c

4 lines

mp_machdep.c

2 lines

Diff 49907

View Options

head/sys/riscv/riscv/intr_machdep.c