Page MenuHomeFreeBSD

Mark Qt4 EOL by March 15th 2019
Needs ReviewPublic

Authored by tcberner on Sun, Oct 28, 7:57 PM.

Details

Reviewers
rene
Group Reviewers
portmgr
kde
O5: Ports Framework(Owns No Changed Paths)
Summary

Qt4 has been EOL since december 2015.

This depends on D17740 for the flavor deprecations.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20867
Build 20245: arc lint + arc unit

Event Timeline

tcberner created this revision.Sun, Oct 28, 7:57 PM
Herald added a subscriber: mat. · View Herald Transcript
rene added a subscriber: rene.Sun, Oct 28, 8:26 PM
rene added inline comments.
archivers/quazip/Makefile
29

Hmm, so how would we handle removed flavors? One way would be to manually edit the affected ports (so for this port it would affect line 16 and lines 25-29 and 34)

tcberner marked an inline comment as done.Sun, Oct 28, 8:35 PM
tcberner added inline comments.
archivers/quazip/Makefile
29

I would just go through the list in march and remove the Qt4 flavors by hand mid march (removing the lines you mentioned). I don't think this can be done savely by a script.

For most the ports affected here, this would basically be a de-flavoring, as @qt5 would be the only flavor then, so FLAVORS should be removed completely for them.

rene requested changes to this revision.Sun, Oct 28, 10:26 PM

There could be more ports where the QT4 dependency is optional, please recheck all ports.Those ports must not expire, only their QT4 bits should be removed manually. Otherwise rmport will happily remove them.

deskutils/recoll/Makefile
16

Double blank line introduced, at least portlint will complain loudly.

devel/plasma/Makefile
13

Another extra blank line.

42

Typo, must be

.include <bsd.port.options.mk>
devel/qjson/Makefile
14

Section separator line removed.

editors/libreoffice/Makefile
18

Only when the non-default option KDE4 is selected.

graphics/fracplanet/Makefile
18

Section separator removed.

graphics/graphviz/Makefile
18

Only when the non-default option GVEDIT is selected.

graphics/yafaray/Makefile
17

Placed in the middle of the license section.

mail/emailrelay/Makefile
19

Only when the non-default option GUI is selected.

multimedia/dvbcut/Makefile
16

Only with the non-default option QT4.

This port could be flavored for QT4 and QT5, but that is unrelated to this review.

print/hplip/Makefile
16

Extra newline inserted.

security/ophcrack/Makefile
17

Only when the option X11 (which is a default) is selected.

security/pinentry/Makefile
18

Only when QT4 is selected.

sysutils/android-file-transfer/Makefile
16

Only for the QT4 case.

textproc/ansifilter/Makefile
18

Only for the non-default QT4 option.

This revision now requires changes to proceed.Sun, Oct 28, 10:26 PM
jhale added a subscriber: jhale.Sun, Oct 28, 11:24 PM

There seems to be quite a few ports here that depend on x11/kdelibs-kde4 which is set to be removed on 2018-12-31. Shouldn’t those ports also be removed on 2018-12-31?

tcberner marked 12 inline comments as done.Mon, Oct 29, 5:57 AM
In D17741#379148, @rene wrote:

There could be more ports where the QT4 dependency is optional, please recheck all ports.Those ports must not expire, only their QT4 bits should be removed manually. Otherwise rmport will happily remove them.

You're right, I only went through ports with FLAVORS and fixed the options that appeared in there.

editors/libreoffice/Makefile
18

this option should probably be marked for removal for december (kde4)

graphics/yafaray/Makefile
17

also moved to only match QT option.

multimedia/dvbcut/Makefile
16

probably also not worth it... :)

tcberner updated this revision to Diff 49748.Mon, Oct 29, 6:36 AM
tcberner marked 3 inline comments as done.

Update

There seems to be quite a few ports here that depend on x11/kdelibs-kde4 which is set to be removed on 2018-12-31. Shouldn’t those ports also be removed on 2018-12-31?

I would say so, as they will be broken by the removal.

adridg added a subscriber: adridg.Mon, Oct 29, 9:12 AM

There seems to be quite a few ports here that depend on x11/kdelibs-kde4 which is set to be removed on 2018-12-31. Shouldn’t those ports also be removed on 2018-12-31?

I would say so, as they will be broken by the removal.

I did a quick grep USES.*kde:4 a while back and contacted the maintainers of some of those ports. The following grep is a little broader and catches more (but you're right, just looking for a dependency on kdelibs4 is a better thing):

grep -H ^MAINT $( for d in [a-z]*; do grep -lr "USES.*kde:4" $d/*/Makefile; done ) | grep -v kde@FreeBSD | sort -k 2
jhale added a comment.Mon, Oct 29, 2:58 PM

Option corrections. :)

audio/qsampler/Makefile
15

Only for QT4 option. QT5 option is default.

audio/rosegarden/Makefile
16

Only for QT4 option. QT5 option available.

deskutils/cairo-dock-plugins/Makefile
14

KDE_INTEGRATION option only. Should be removed with KDE4.

deskutils/fbreader/Makefile
15

QT4 option only. GTK2 option available.

devel/gwenhywfar/Makefile
15

qt4 slave port only

editors/mp/Makefile
16

QT4 option only. (non-default)

editors/tea/Makefile
13

Only for QT4 option. QT5 option available.

editors/texmacs/Makefile
17

QT4 option only.

emulators/yabause/Makefile
14

Only for QT4 option. QT5 option available.

graphics/gnash/Makefile
16 ↗(On Diff #49748)

Only KDE4 option. Should be removed with KDE4.

graphics/openimageio/Makefile
15

Only for IMAGEVIEWER option.

graphics/osg-devel/Makefile
21

Only for QT4 option. QT5 option available.

graphics/osg/Makefile
18

Only for QT4 option. QT5 option available.

graphics/poppler/Makefile
16

Only for QT4 slave port.

graphics/qtawesome/Makefile
13

QT4 option only. QT5 option available.

graphics/tulip/Makefile
16

QT4 option only. QT5 option available.

java/classpath/Makefile
21

QT4 option only.

math/py-matplotlib/Makefile
57

Character insertion?

math/vtk5/Makefile
17 ↗(On Diff #49748)

Only QT4 option.

multimedia/avidemux/Makefile
15

Only QT4 option. GTK3 option available.

multimedia/smplayer/Makefile
15

Only QT4 option. QT5 is currently the default.

multimedia/smtube/Makefile
15

Only QT4 option. QT5 is currently the default.

net-im/ekiga/Makefile
18 ↗(On Diff #49748)

Only the KDE and KAB options. They should be removed when KDE4 is removed.

net-im/qxmpp/Makefile
15

This is a master port to a Qt5 slave port. Only the Qt4 part should be DEPRECATED.

net-p2p/zetacoin/Makefile
15

Only X11 option.

ports-mgmt/packagekit/Makefile
14

The qt4 part of this was for a slave port that was removed in in r450874. Considering this port has been marked IGNORE for over 3 years, it might be time for it to go anyways.

print/qpdfview/Makefile
17

Only default QT4 option should be DEPRECATED. QT5 option available; should probably be switched.

science/silo/Makefile
17

Only non-default QT4 option.

security/quantis/Makefile
16

Only the GUI option uses Qt4.

security/xca/Makefile
15

Only QT4 option should be DEPRECATED. QT4 is currently the default. Should probably be switched to QT5 with a PORTREVISION bump.

x11-themes/qtcurve/Makefile
32

Only x11-themes/qtcurve-qt4 should be DEPRECATED. Defining it here deprecates all of the qtcurve ports.

Option corrections. :)

Thanks for the list! I'll try to follow up on it tomorrow.

rene requested changes to this revision.Sun, Nov 11, 6:16 PM
rene added inline comments.
audio/liblastfm/Makefile
16

Extra line inserted.

audio/minitunes/Makefile
28

Out of order, but this port is a mess in that regard anyway.

graphics/graphviz/Makefile
15

Separator line removed.

print/qpdfview/Makefile
17

Indeed, please switch to QT5 as default.

security/ike/Makefile
14

Extra blank line inserted.

security/keepassx2/Makefile
19

Placed in the middle of the license section.

security/xca/Makefile
15

Yes, please switch to QT5.

security/yubikey-personalization-gui/Makefile
16

Only for non-default QT4 option.

This revision now requires changes to proceed.Sun, Nov 11, 6:16 PM
tcberner updated this revision to Diff 50541.Sat, Nov 17, 9:49 PM

Address @rene's comments.