Page MenuHomeFreeBSD
Differential D17705

Suggest upload of dmesg in login fortune file
ClosedPublic
Actions

Authored by bcr on Oct 25 2018, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 3:54 PM
Unknown Object (File)
Sun, Apr 28, 3:54 PM
Unknown Object (File)
Sun, Apr 28, 3:54 PM
Unknown Object (File)
Sun, Apr 28, 3:54 PM
Unknown Object (File)
Sun, Apr 28, 3:54 PM
Unknown Object (File)
Sun, Apr 28, 3:40 AM
Unknown Object (File)
Mar 1 2024, 5:24 AM
Unknown Object (File)
Feb 5 2024, 10:38 PM
View All 21 Files
Subscribers
kalle.carlbark_freebsd_kcbark.net

Details

Reviewers
imp
jhb
allanjude
brooks
Commits
rS340870: MFC r340649:
rS340649: Add a fortune describing how to upload a machine's dmesg information to the
Summary

We should encourage users to upload their dmesg to the NYCBUG database to get a better feel on which hardware FreeBSD is run on. This patch is a first attempt at adding such an entry to the fortune file.
The command I used is the one posted on this thread:
http://lists.nycbug.org:8080/pipermail/talk/2018-October/017729.html

Question: How do we best reference where the data is going (NYCBUG)? Do we add a note that users might upload potentially sensitive information about their systems like serial numbers this way?

Note: I chose not to add a name to the fortune, not all of them have one. I'm also not opposed to adding a name to it. The command did not originate from me, so attribution should go to the proper author.

Suggestions welcome.

Test Plan
  1. Apply the attached patch to head/usr.bin/fortune/datfiles/freebsd-tips
  2. run make in that directory
  3. To view the fortune, run: fortune -m curl freebsd-tips

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bcr created this revision.Oct 25 2018, 7:11 PM
Harbormaster completed remote builds in B20427: Diff 49624.Oct 25 2018, 7:11 PM
kalle.carlbark_freebsd_kcbark.net added a subscriber: kalle.carlbark_freebsd_kcbark.net.Oct 26 2018, 9:17 PM
brooks added inline comments.Nov 1 2018, 5:32 PM
head/usr.bin/fortune/datfiles/freebsd-tips
558

Maybe "the curl package"?

559

Does it make sense to wrap this with backslashes at <80 columns due to the potential for terminal damage?

bcr updated this revision to Diff 49899.Nov 1 2018, 6:52 PM

Update with suggestions from Brooks:

  • use "the curl package"
  • use \ to wrap long lines
bcr added a comment.Nov 16 2018, 10:44 AM

ping? I think we can add it and see how it works out regarding the data collection we are trying to do.

imp added a comment.Nov 16 2018, 5:43 PM

I don't think we need email= anymore.

bcr updated this revision to Diff 50492.Nov 16 2018, 5:53 PM

Removed the email= part.

bcr marked 2 inline comments as done.Nov 16 2018, 5:54 PM

Belatedly mark comments as done.

allanjude accepted this revision.Nov 19 2018, 8:31 PM
This revision is now accepted and ready to land.Nov 19 2018, 8:31 PM
Closed by commit rS340649: Add a fortune describing how to upload a machine's dmesg information to the (authored by bcr). · Explain WhyNov 19 2018, 8:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
fortune/
datfiles/
6 lines

Diff 50613

View Options

head/usr.bin/fortune/datfiles/freebsd-tips

Loading...