address late reviewer concerns about helper functions patch
AbandonedPublic
Actions

Authored by dougm on Oct 21 2018, 6:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 7, 5:35 AM

	Unknown Object (File)
	Mon, Nov 3, 12:32 PM

	Unknown Object (File)
	Mon, Nov 3, 12:31 PM

	Unknown Object (File)
	Mon, Nov 3, 12:31 PM

	Unknown Object (File)
	Sat, Nov 1, 8:08 PM

	Unknown Object (File)
	Tue, Oct 28, 10:51 AM

	Unknown Object (File)
	Sat, Oct 18, 9:28 PM

	Unknown Object (File)
	Wed, Oct 15, 5:21 PM

View All 63 Files

Subscribers

None

Details

Reviewers

alc
kib
markj

Summary

Make style and formatting changes recommended in a late review of D17610: Use helper functions to reduce code duplication in merging vm_entry neighbors

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm created this revision.Oct 21 2018, 6:01 PM

alc added inline comments.Oct 21 2018, 6:18 PM

sys/vm/vm_map.c
1647	vm_map_simplify_test() so that people only see this function as a helper to vm_map_simplify_entry().
1663	vm_map_simplify_deallocate()

Add 'simplify' to 'neighbor' function names.

dougm added reviewers: kib, markj.Oct 21 2018, 7:20 PM

The concerns that this change would address will be addressed elsewhere.

So what is going on with these corrections ?

In D17639#379371, @kib wrote:

So what is going on with these corrections ?

D17635 Avoid duplicate set_max_free after unlink
will address them, once D14005 is committed.
Unless something else comes up.

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_map.c

34 lines

Diff 49407

View Options

address late reviewer concerns about helper functions patchAbandonedPublicActions