Page MenuHomeFreeBSD
Differential D17639

address late reviewer concerns about helper functions patch
AbandonedPublic
Actions

Authored by dougm on Oct 21 2018, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 5:21 PM
Unknown Object (File)
Wed, Oct 15, 5:20 PM
Unknown Object (File)
Wed, Oct 15, 5:20 PM
Unknown Object (File)
Wed, Oct 15, 6:42 AM
Unknown Object (File)
Sep 6 2025, 2:00 PM
Unknown Object (File)
Aug 3 2025, 1:36 PM
Unknown Object (File)
Jul 12 2025, 12:37 PM
Unknown Object (File)
Jun 28 2025, 10:12 PM
View All 56 Files
Subscribers
None

Details

Reviewers
alc
kib
markj
Summary

Make style and formatting changes recommended in a late review of D17610: Use helper functions to reduce code duplication in merging vm_entry neighbors

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Oct 21 2018, 6:01 PM
alc added inline comments.Oct 21 2018, 6:18 PM
sys/vm/vm_map.c
1647

vm_map_simplify_test() so that people only see this function as a helper to vm_map_simplify_entry().

1663

vm_map_simplify_deallocate()

dougm updated this revision to Diff 49407.Oct 21 2018, 6:22 PM

Add 'simplify' to 'neighbor' function names.

dougm added reviewers: kib, markj.Oct 21 2018, 7:20 PM
dougm abandoned this revision.Oct 21 2018, 9:15 PM

The concerns that this change would address will be addressed elsewhere.

kib added a comment.Oct 29 2018, 7:53 PM

So what is going on with these corrections ?

dougm added a comment.Oct 29 2018, 7:59 PM
In D17639#379371, @kib wrote:

So what is going on with these corrections ?

D17635 Avoid duplicate set_max_free after unlink
will address them, once D14005 is committed.
Unless something else comes up.

Revision Contents
Changeset List

PathSize
sys/
vm/
34 lines

Diff 49407

View Options

sys/vm/vm_map.c

Loading...