Page MenuHomeFreeBSD

address late reviewer concerns about helper functions patch
AbandonedPublic

Authored by dougm on Oct 21 2018, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 5, 3:26 AM
Unknown Object (File)
Wed, Feb 5, 3:06 AM
Unknown Object (File)
Tue, Feb 4, 2:41 PM
Unknown Object (File)
Tue, Feb 4, 9:29 AM
Unknown Object (File)
Sat, Feb 1, 1:30 PM
Unknown Object (File)
Jan 14 2025, 4:57 PM
Unknown Object (File)
Nov 29 2024, 12:33 AM
Unknown Object (File)
Nov 29 2024, 12:33 AM
Subscribers
None

Details

Reviewers
alc
kib
markj
Summary

Make style and formatting changes recommended in a late review of D17610: Use helper functions to reduce code duplication in merging vm_entry neighbors

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sys/vm/vm_map.c
1647

vm_map_simplify_test() so that people only see this function as a helper to vm_map_simplify_entry().

1663

vm_map_simplify_deallocate()

Add 'simplify' to 'neighbor' function names.

The concerns that this change would address will be addressed elsewhere.

So what is going on with these corrections ?

In D17639#379371, @kib wrote:

So what is going on with these corrections ?

D17635 Avoid duplicate set_max_free after unlink
will address them, once D14005 is committed.
Unless something else comes up.