Add an assertion to pmap_enter().
ClosedPublic
Actions

Authored by markj on Oct 20 2018, 8:03 PM.

Details

Reviewers

alc
kib

Commits

rS339490: Add an assertion to pmap_enter().

Summary

When faulting on an existing mapping, if the mapping is managed, it
should have a PV entry. Verify this.

I found this useful while debugging some modifications.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 20 2018, 8:03 PM

Harbormaster completed remote builds in B20308: Diff 49350.Oct 20 2018, 8:03 PM

markj added reviewers: alc, kib.Oct 20 2018, 8:05 PM

alc added inline comments.Oct 20 2018, 8:12 PM

sys/amd64/amd64/pmap.c
5063 ↗	(On Diff #49350)	Based on line 5047, `(origpte & PG_MANAGED) == 0` can never be true.

Address Alan's comment.

Harbormaster completed remote builds in B20309: Diff 49353.Oct 20 2018, 8:21 PM

markj added inline comments.Oct 20 2018, 8:21 PM

sys/amd64/amd64/pmap.c
5063 ↗	(On Diff #49350)	Thanks, I originally had this assertion further down.

kib accepted this revision.Oct 20 2018, 8:25 PM

This revision is now accepted and ready to land.Oct 20 2018, 8:25 PM

alc accepted this revision.Oct 20 2018, 8:27 PM

Closed by commit rS339490: Add an assertion to pmap_enter(). (authored by markj). · Explain WhyOct 20 2018, 8:53 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptOct 20 2018, 8:53 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

pmap.c

2 lines

i386/

pmap.c

2 lines

Diff 49357

View Options

head/sys/amd64/amd64/pmap.c