Page MenuHomeFreeBSD
Differential D17626

Add an assertion to pmap_enter().
ClosedPublic
Actions

Authored by markj on Oct 20 2018, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 5:51 AM
Unknown Object (File)
Fri, Feb 28, 12:12 PM
Unknown Object (File)
Sun, Feb 23, 12:30 AM
Unknown Object (File)
Feb 20 2025, 5:56 PM
Unknown Object (File)
Feb 6 2025, 4:52 AM
Unknown Object (File)
Jan 14 2025, 3:18 AM
Unknown Object (File)
Jan 9 2025, 5:28 AM
Unknown Object (File)
Dec 28 2024, 6:58 PM
View All 51 Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rS339490: Add an assertion to pmap_enter().
Summary

When faulting on an existing mapping, if the mapping is managed, it
should have a PV entry. Verify this.

I found this useful while debugging some modifications.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Oct 20 2018, 8:03 PM
Harbormaster completed remote builds in B20308: Diff 49350.Oct 20 2018, 8:03 PM
markj added reviewers: alc, kib.Oct 20 2018, 8:05 PM
alc added inline comments.Oct 20 2018, 8:12 PM
sys/amd64/amd64/pmap.c
5063 ↗(On Diff #49350)

Based on line 5047, (origpte & PG_MANAGED) == 0 can never be true.

markj updated this revision to Diff 49353.Oct 20 2018, 8:21 PM
markj marked 2 inline comments as done.
  • Address Alan's comment.
Harbormaster completed remote builds in B20309: Diff 49353.Oct 20 2018, 8:21 PM
markj added inline comments.Oct 20 2018, 8:21 PM
sys/amd64/amd64/pmap.c
5063 ↗(On Diff #49350)

Thanks, I originally had this assertion further down.

kib accepted this revision.Oct 20 2018, 8:25 PM
This revision is now accepted and ready to land.Oct 20 2018, 8:25 PM
alc accepted this revision.Oct 20 2018, 8:27 PM
Closed by commit rS339490: Add an assertion to pmap_enter(). (authored by markj). · Explain WhyOct 20 2018, 8:53 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptOct 20 2018, 8:53 PM

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
2 lines
i386/
i386/
2 lines

Diff 49357

View Options

head/sys/amd64/amd64/pmap.c

Show First 20 Lines • Show All 94 Lines • ▼ Show 20 Lines
# the QMAKE_ARGS. # the QMAKE_ARGS.
# ${opt}_QMAKE_OFF When option is disabled, it will add its content to # ${opt}_QMAKE_OFF When option is disabled, it will add its content to
# the QMAKE_ARGS. # the QMAKE_ARGS.
# #
# ${opt}_IMPLIES When opt is enabled, options named in IMPLIES will # ${opt}_IMPLIES When opt is enabled, options named in IMPLIES will
# get enabled too. # get enabled too.
# ${opt}_PREVENTS When opt is enabled, if any options in PREVENTS are # ${opt}_PREVENTS When opt is enabled, if any options in PREVENTS are
# also enabled, it will produce an error. # also enabled, it will produce an error.
# ${opt}_PREVENTS_MSG Provides a message explaining why the options
# cannot be selected together.
# #
# ${opt}_USE= FOO=bar When option is enabled, it will enable # ${opt}_USE= FOO=bar When option is enabled, it will enable
# USE_FOO+= bar # USE_FOO+= bar
# If you need more than one option, you can do # If you need more than one option, you can do
# FOO=bar,baz and you'll get USE_FOO=bar baz # FOO=bar,baz and you'll get USE_FOO=bar baz
# ${opt}_USE_OFF= FOO=bar When option is disabled, it will enable # ${opt}_USE_OFF= FOO=bar When option is disabled, it will enable
# USE_FOO+= bar # USE_FOO+= bar
# #
▲ Show 20 Lines • Show All 426 Lines • Show Last 20 Lines
View Options

head/sys/i386/i386/pmap.c

Show First 20 Lines • Show All 94 Lines • ▼ Show 20 Lines
# the QMAKE_ARGS. # the QMAKE_ARGS.
# ${opt}_QMAKE_OFF When option is disabled, it will add its content to # ${opt}_QMAKE_OFF When option is disabled, it will add its content to
# the QMAKE_ARGS. # the QMAKE_ARGS.
# #
# ${opt}_IMPLIES When opt is enabled, options named in IMPLIES will # ${opt}_IMPLIES When opt is enabled, options named in IMPLIES will
# get enabled too. # get enabled too.
# ${opt}_PREVENTS When opt is enabled, if any options in PREVENTS are # ${opt}_PREVENTS When opt is enabled, if any options in PREVENTS are
# also enabled, it will produce an error. # also enabled, it will produce an error.
# ${opt}_PREVENTS_MSG Provides a message explaining why the options
# cannot be selected together.
# #
# ${opt}_USE= FOO=bar When option is enabled, it will enable # ${opt}_USE= FOO=bar When option is enabled, it will enable
# USE_FOO+= bar # USE_FOO+= bar
# If you need more than one option, you can do # If you need more than one option, you can do
# FOO=bar,baz and you'll get USE_FOO=bar baz # FOO=bar,baz and you'll get USE_FOO=bar baz
# ${opt}_USE_OFF= FOO=bar When option is disabled, it will enable # ${opt}_USE_OFF= FOO=bar When option is disabled, it will enable
# USE_FOO+= bar # USE_FOO+= bar
# #
▲ Show 20 Lines • Show All 426 Lines • Show Last 20 Lines