Add NVIDIA_GL description to Mk/bsd.options.desc.mk

[xmj]

Summary

Add NVIDIA_GL description to Mk/bsd.options.desc.mk

• Add NVIDIA_GL description to Mk/bsd.options.desc.mk
• Remove NVIDIA_GL_DESC from all concerned ports
• Use options helpers where adequate.

Approved by: koobs (mentor)
Approved by: blanket (portmgr)

Test Plan

http://xmj.me/freebsd/buildlogs/linux-c6-qt47-x11-4.7.2_1.log
http://xmj.me/freebsd/buildlogs/linux-c6-glx-utils-10.1.2.log
http://xmj.me/freebsd/buildlogs/linux-c6-0.2.log
http://xmj.me/freebsd/buildlogs/linux-f10-0.2.log
http://xmj.me/freebsd/buildlogs/linux-doom3-demo-1.1.1286_2.log
http://xmj.me/freebsd/buildlogs/linux-enemyterritory-2.60b_3.log
http://xmj.me/freebsd/buildlogs/linux-rtcw-1.41.b_2.log
http://xmj.me/freebsd/buildlogs/linux-unigine-heaven-4.0.log
http://xmj.me/freebsd/buildlogs/linux-ut2003-demo-2206.log
http://xmj.me/freebsd/buildlogs/skype-2.1.0.81_1,1.log
http://xmj.me/freebsd/buildlogs/skype-devel-2.2.0.35_1.log

[koobs]

Mk/bsd.options.desc.mk

348

Thinking of the users, might "OpenGL via x11/nvidia-driver" be a clearer / more meaningful description?

What about GL_NDIVIA?
Whats the other libGL option via?

games/linux-enemyterritory/Makefile

26–27

What about NVIDIA_GL_USE_OFF= LINUX_APPS=dri ? (see Mk/bsd.options.mk)

games/linux-rtcw/Makefile

34

OPTIONS helper?

games/linux-ut2003-demo/Makefile

44

As above

graphics/linux-c6-glx-utils/Makefile

23

Why isn't this USE_LINUX_APPS+= dri as other ports?

net-im/skype-devel/Makefile

17–18

Sort OPTIONS

20–21

Group OPTIONS_*

net-im/skype/Makefile

16–17

Sort

18

Group OPTIONS_*

[xmj]

CRF: Skype options sorting/grouping

Mk/bsd.options.desc.mk

348

The way I've (re)written it is to fit in with the other entries up/down in bsd.options.desk.mk, and... because it makes sense.

GL_NVIDIA sounds weird to my ears, but that may be habituation..
alternative is "plain" graphics/libGL from Mesa

games/linux-enemyterritory/Makefile

26–27

USE_LINUX_APPS, pulling in Mk/bsd.linux-apps.mk, isn't equal to USES= dri pulling in Mk/Uses/dri.mk

games/linux-rtcw/Makefile

34

Assuming NVIDIA_GL_EXTVER below is meaningful, this can stay without option helper

34

If I have to have an if clause anyway, due to

NVIDIA_GL_EXTVER, and
USE_LINUX_APPS (below), then options helpers won't make any sense.

games/linux-ut2003-demo/Makefile

44

As above. USE_LINUX_APPS isn't replaced by options helpers.

graphics/linux-c6-glx-utils/Makefile

23

Others allow for conditionally pulling in fedora10, or centos6, depending on what the user has set OVERRIDE_LINUX_BASE_PORT/OVERRIDE_LINUX_NONBASE_PORTS to in make.conf

This port being a port that 1. defines USE_LINUX=c6 2. uses c6 itself,
making it possible to depend on fedora 10 stuff is not a good idea and hence explicit dep preferred.

34

USE_LINUX_APPS not needed, c6 port

x11-toolkits/linux-c6-qt47-x11/Makefile

31

USE_LINUX_APPS not needed. it's a c6 port anyway.

[mat]

games/linux-doom3-demo/Makefile

36–37

NVIDIA_GL_USE_OFF= linux_apps=dri

games/linux-enemyterritory/Makefile

26–28

NVIDIA_GL_USE_OFF= linux_apps=dri

graphics/linux-c6-glx-utils/Makefile

23

NVIDIA_GL_USE_OFF= linux_apps=dri

I think.

x11-toolkits/linux-c6-qt47-x11/Makefile

26

NVIDIA_GL_USE_OFF= linux_apps=dri

same ?

[xmj]

CRF: OPTIONS_HELPER work also for USE_${FOO} where ${FOO} is arbitrary.

[bapt]

This accept is for the description I'll let your maintainers decide about other parts :)

[koobs]

Mk/bsd.options.desc.mk

348

Should this mention "(Uses DRI when Disabled)" ?

[koobs]

Good to go

[xmj]

Committed revision @rP383259.

[cperciva]

games/linux-enemyterritory/Makefile

57

This needs to be above do-install: