Page MenuHomeFreeBSD

Move 32-bit compat support for FIODGNAME to the right place.
ClosedPublic

Authored by brooks on Oct 8 2018, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 29, 11:43 PM
Unknown Object (File)
Fri, Sep 27, 5:50 AM
Unknown Object (File)
Wed, Sep 11, 5:09 AM
Unknown Object (File)
Sat, Sep 7, 5:23 PM
Unknown Object (File)
Sat, Sep 7, 11:48 AM
Unknown Object (File)
Sep 2 2024, 4:44 PM
Unknown Object (File)
Sep 2 2024, 7:51 AM
Unknown Object (File)
Aug 31 2024, 10:34 PM
Subscribers

Details

Summary

ioctl(2) commands only have meaning in the context of a file descriptor
so translating them in the syscall layer is incorrect.

The new handler users an accessor to retrieve/construct a pointer from
the last member of the passed structure and relies on type punning to
access the other member which requires no translation.

Unlike r339174 this change supports both places FIODGNAME is handled.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20074
Build 19573: arc lint + arc unit

Event Timeline

kib added inline comments.
sys/kern/tty_pts.c
299

return (copyout(...));

This revision is now accepted and ready to land.Oct 8 2018, 8:12 PM
  • style(9) as pointed out by @kib
This revision now requires review to proceed.Oct 8 2018, 8:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 26 2018, 5:59 PM
This revision was automatically updated to reflect the committed changes.