security/openssl111: Fix linking with lld on i386
ClosedPublic
Actions

Authored by brnrd on Sep 30 2018, 11:12 AM.

Details

Reviewers

ndowens_yahoo.com
emaste

Commits

rP481266: security/openssl111: Fix linking with lld on i386

Summary

security/openssl111: Fix linking with lld on i386

 - Fix shared option
 - While here, fix ordering

PR:		231459
Submitted by:	Nathan <ndowens yahoo com>
Reported by:	emaste
Differential_Revision:	https://reviews.freebsd.org/D17362

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brnrd created this revision.Sep 30 2018, 11:12 AM

Herald added a subscriber: mat. · View Herald TranscriptSep 30 2018, 11:12 AM

Harbormaster completed remote builds in B19881: Diff 48588.Sep 30 2018, 11:12 AM

brnrd edited the summary of this revision. (Show Details)Sep 30 2018, 11:13 AM

brnrd added a reviewer: ndowens_yahoo.com.

Fix is needed for i386, not amd64

Harbormaster completed remote builds in B19882: Diff 48589.Sep 30 2018, 11:16 AM

brnrd retitled this revision from security/openssl111: Fix linking with lld to security/openssl111: Fix linking with lld on i386.Sep 30 2018, 11:17 AM

brnrd edited the summary of this revision. (Show Details)

brnrd edited the summary of this revision. (Show Details)Sep 30 2018, 11:30 AM

brnrd edited reviewers, added: emaste; removed: ed.

ndowens_yahoo.com added inline comments.Sep 30 2018, 3:54 PM

security/openssl111/Makefile
28 ↗	(On Diff #48589)	USES= and USE_* Should be above HAS_CONFIGURE, but below CONFLICTS According to handbook

mat added inline comments.Oct 1 2018, 1:32 PM

security/openssl111/Makefile
28 ↗	(On Diff #48589)	Unless I missed something, there is nothing about CONFLICTS variable being special in chapter 15. So they go in the `Standard bsd.port.mk Variables` block.