Page MenuHomeFreeBSD

Mark various removed system calls as OBSOL instead of UNIMPL.
ClosedPublic

Authored by jhb on Sep 28 2018, 12:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 11:25 PM
Unknown Object (File)
Sat, Dec 14, 4:46 PM
Unknown Object (File)
Sep 25 2024, 10:50 PM
Unknown Object (File)
Sep 25 2024, 9:55 AM
Unknown Object (File)
Sep 24 2024, 9:34 PM
Unknown Object (File)
Sep 24 2024, 4:14 AM
Unknown Object (File)
Sep 24 2024, 2:32 AM
Unknown Object (File)
Sep 22 2024, 11:48 PM
Subscribers

Details

Summary

This is mostly a cosmetic change except that obsolete system calls are
assigned meaningful names in the names arrays which means that using
tools like kdump or truss against binaries invoking these system calls
will print out the name instead of the number. The script I use to
generate the XML list of syscalls for GDB also ignore UNIMPL but not
OBSOL entries. In general UNIMPL should only be used to reserve
placeholders for system calls that have never been implemented while
system calls that existed at one time in FreeBSD but were removed
should be marked OBSOL instead.

I noticed this when I was going to update the XML syscall list for GDB
for 12.0 and noticed it would remove the numa_* syscalls added in 11
which isn't quite friendly since GDB can be used on 11 still.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Are the real changes only in syscall.masters ? The syscall.master' diffs look fine.

This revision is now accepted and ready to land.Sep 28 2018, 12:38 PM

This looks great to me. A tiny bit more memory usage for the strings, but that's small potatoes.

In D17344#369936, @kib wrote:

Are the real changes only in syscall.masters ? The syscall.master' diffs look fine.

The real changes are only there, but I did include the generated diff as well. Most of the generated changes are to comments except for freebsd32_syscalls.c and syscalls.c where some of the string constants change.

This revision was automatically updated to reflect the committed changes.