Page MenuHomeFreeBSD

Eliminate unnecessary uses of UMA_ZONE_NOFREE from the swap pager
ClosedPublic

Authored by alc on Sep 22 2018, 10:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:37 AM
Unknown Object (File)
Nov 6 2023, 10:03 PM
Unknown Object (File)
Sep 15 2023, 9:45 PM
Unknown Object (File)
Sep 11 2023, 4:51 AM
Unknown Object (File)
Aug 27 2023, 6:54 AM
Unknown Object (File)
Jul 10 2023, 4:06 AM
Unknown Object (File)
May 17 2023, 12:43 AM
Unknown Object (File)
May 8 2023, 5:29 PM
Subscribers

Details

Summary

Passing UMA_ZONE_NOFREE to uma_zcreate() for swpctrie_zone and swblk_zone is redundant, because uma_zone_reserve_kva() is performed on both zones and it sets this same flag on the zone.

Moreover, I don't see why the swap pager would require either zone to be UMA_ZONE_NOFREE.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I believe NOFREE there is to reduce risk of the deadlock due to the allocation, and not to prevent memory type change.

This revision is now accepted and ready to land.Sep 23 2018, 3:33 PM
In D17296#368720, @kib wrote:

I believe NOFREE there is to reduce risk of the deadlock due to the allocation, and not to prevent memory type change.

Me too. I would hope, if not expect, that our use of M_USE_RESERVE on allocations by the page daemon would suffice.

This revision was automatically updated to reflect the committed changes.