Page MenuHomeFreeBSD

Define a ifunc-noplt linker feature.
AbandonedPublic

Authored by markj on Sep 21 2018, 10:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 12:50 AM
Unknown Object (File)
Oct 31 2024, 2:19 PM
Unknown Object (File)
Oct 23 2024, 4:59 AM
Unknown Object (File)
Oct 18 2024, 6:37 AM
Unknown Object (File)
Oct 4 2024, 5:36 AM
Unknown Object (File)
Oct 1 2024, 7:50 PM
Unknown Object (File)
Oct 1 2024, 5:17 AM
Unknown Object (File)
Oct 1 2024, 4:08 AM

Details

Reviewers
emaste
bdrewery
Summary

Also enable -zifunc-noplt on i386, now that we have some uses of ifuncs
there.

Test Plan

Booted an i386 kernel that uses ifuncs.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19738
Build 19299: arc lint + arc unit

Event Timeline

markj added a reviewer: emaste.
imp added inline comments.
share/mk/bsd.linker.mk
89

Is the linker version the HOST linker or the TARGET linker?
Wouldn't this create bootstrapping issues?

sys/conf/kern.pre.mk
126

Do we need to restrict this only to building targets? Installing should be fine, and any tree-traversal should be fine. And they are often done before we've bootstrapped.

markj added inline comments.
share/mk/bsd.linker.mk
89

It should be whichever linker is used during the build.

sys/conf/kern.pre.mk
126

Right, we only need this seatbelt for builds, not for installing. That's orthogonal to my diff though.

This revision is now accepted and ready to land.Oct 1 2018, 7:20 PM

mmm, I need to test -zifunc-noplt with arm64 now.

Doesn't seem to be useful after all.