lang/rust: unbundle libgit2 and libssh2
ClosedPublic
Actions

Authored by jbeich on Sep 20 2018, 11:06 AM.

Details

Reviewers

dumbbell
riggs
tobik
koobs
will

Summary

Bundled libs are undesirable. libssh2 upstream has some fixes since 1.8.0 but nothing particularly important. As for libgit2 our version is newer than what rust-1.29.0 bundles.

Test Plan

poudriere bulk -tj 112amd64 -z libressl lang/rust is green.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 19696
Build 19260: arc lint + arc unit

Event Timeline

jbeich created this revision.Sep 20 2018, 11:06 AM

Harbormaster completed remote builds in B19695: Diff 48261.Sep 20 2018, 11:06 AM

@koobs, can you create rust project/team on phabricator, so one doesn't have to poke /etc/aliases on freefall just to figure out the roster in order to populate reviewers ?

I was about to test a similar change during the week-end and that's what OpenBSD does (the maintainer is quite active in the Rust community). So yes, let's try that!

This revision is now accepted and ready to land.Sep 20 2018, 11:30 AM

dumbbell added inline comments.Sep 20 2018, 11:32 AM

lang/rust/Makefile
35	One small comment about ordering: can you please order them based on the library name instead of the port category?

Also switch USES=cargo to system libssh2 (unused atm)

This revision now requires review to proceed.Sep 20 2018, 11:33 AM

Harbormaster completed remote builds in B19696: Diff 48262.Sep 20 2018, 11:34 AM

tobik accepted this revision.Sep 20 2018, 12:06 PM

This revision is now accepted and ready to land.Sep 20 2018, 12:06 PM

Landed in rP480253.

jbeich marked 2 inline comments as done.Sep 21 2018, 11:32 AM

jbeich added inline comments.

lang/rust/Makefile
35	Sorry, I forgot about this minor bit thus fixed in a separate commit. Neither Porter's Handbook nor portlint seem to care about order in *_DEPENDS defined in port's Makefile.