Page MenuHomeFreeBSD

Add support for EC2 i3.metal serial port
ClosedPublic

Authored by cperciva on Sep 19 2018, 9:26 PM.

Details

Summary

Recognize the Amazon PCI serial device found in i3.metal EC2 instances
as an NS8250 UART.

Test Plan

Booting an EC2 i3.metal instance with this patch, uart2 shows up and if I write to it (e.g., cat /COPYRIGHT > /dev/ttyu2) that shows up in the EC2 Console Logs.

Unfortunately I haven't been able to figure out how to get the kernel to use this for its console output, which is kind of the point... any help will be much appreciated.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cperciva created this revision.Sep 19 2018, 9:26 PM

Adding some reviewers who have touched this recently and may be able to tell me if I'm doing this right and/or what I'm missing.

This revision is now accepted and ready to land.Sep 19 2018, 10:01 PM
imp accepted this revision.Sep 19 2018, 10:08 PM
imp added inline comments.
sys/dev/uart/uart_bus_pci.c
128 ↗(On Diff #48241)

It's traditional to also add this to puc, iirc.

This revision was automatically updated to reflect the committed changes.