Page MenuHomeFreeBSD

Hoist LDFLAGS_${ARCH} into bsd.port.mk
ClosedPublic

Authored by emaste on Sep 18 2018, 2:41 PM.

Details

Reviewers
bapt
Group Reviewers
portmgr

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste created this revision.Sep 18 2018, 2:41 PM
bapt accepted this revision.Sep 18 2018, 2:42 PM
This revision is now accepted and ready to land.Sep 18 2018, 2:42 PM
emaste closed this revision.Sep 18 2018, 2:49 PM
mmokhi added a subscriber: mmokhi.Sep 18 2018, 3:44 PM

while we are here I'd like to mention this relevant review which maybe some people have opinions on as well 😅

while we are here I'd like to mention this relevant review which maybe some people have opinions on as well 😅

Indeed, that approach would be convenient but some folks didn't like it :)

That said, I now think it doesn't matter much: LDFLAGS_i386=-Wl,-znotext perhaps has less semantic meaning, but is just as much of a nop as D16817 when ld.bfd is in use.

mat added a subscriber: mat.Sep 18 2018, 5:03 PM
mat added inline comments.
Mk/bsd.port.mk
2065

technically, the .if is useless, and if it was supposed to be meaningful, it should probably be .if !empty(LDFLAGS_${ARCH})

emaste marked an inline comment as done.Sep 18 2018, 5:10 PM
emaste added inline comments.
Mk/bsd.port.mk
2065

I was just following the approach for ${lang}FLAGS_${ARCH} above. Shall I take the .if out?

emaste marked an inline comment as done.Sep 18 2018, 5:11 PM
emaste added inline comments.
Mk/bsd.port.mk
2065

(Please explicit Approved by: portmgr if so)

mat added inline comments.Sep 18 2018, 5:35 PM
Mk/bsd.port.mk
2065

Yes, please, and the .if on line 2060, approved by portmgr.