Page MenuHomeFreeBSD
Differential D17207

www/chromium: Fix build on aarch64
ClosedPublic
Actions

Authored by manu on Sep 17 2018, 4:39 PM.
Tags
None
Referenced Files
F152645017: D17207.diff
Thu, Apr 16, 5:57 AM
Unknown Object (File)
Fri, Apr 10, 10:02 PM
Unknown Object (File)
Fri, Apr 10, 9:57 PM
Unknown Object (File)
Thu, Apr 9, 10:58 AM
Unknown Object (File)
Thu, Apr 9, 1:38 AM
Unknown Object (File)
Mon, Apr 6, 5:49 AM
Unknown Object (File)
Sun, Apr 5, 4:38 AM
Unknown Object (File)
Sat, Apr 4, 11:36 AM
View All Files
Subscribers
cpm
emaste
mat

Details

Reviewers
bapt
cpm
Group Reviewers
chromium
Commits
rP485933: www/chromium: Fix build on aarch64
Summary

arm64 doesn't have elf_aux_info and FreeBSD doesn't support getauxval.
For both boringssl and zlib disable the feature checking until we have
a way to expose those feature to the user.
Remove a patch (patch-third__party_boringssl_src_crypto_cpu-aarch64-linux.c) which is a no op
as all the code in under OPENSSL_LINUX which isn't defined.

Test Plan

poudriere ok.
successfully tested on a PineBook.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Sep 17 2018, 4:39 PM
Herald added subscribers: mat, emaste. · View Herald TranscriptSep 17 2018, 4:39 PM
mat added inline comments.Sep 17 2018, 6:23 PM
www/chromium/Makefile
67 ↗(On Diff #48129)

It was ok before.

208–210 ↗(On Diff #48129)

You need a:

.else
PLIST_SUB+= NOT_ARCH64=""
bapt added a comment.Sep 18 2018, 9:01 AM

what @mat says :)

cpm added a subscriber: cpm.Sep 23 2018, 11:14 PM
In D17207#366948, @bapt wrote:

what @mat says :)

What @mat and @bapt say ;)

cpm retitled this revision from www/chromium Fix build on aarch64 to www/chromium: Fix build on aarch64.Sep 23 2018, 11:17 PM
manu updated this revision to Diff 49008.Oct 11 2018, 9:07 AM
manu edited the test plan for this revision. (Show Details)
bapt accepted this revision.Oct 30 2018, 7:56 AM
This revision is now accepted and ready to land.Oct 30 2018, 7:56 AM
cpm accepted this revision.Oct 30 2018, 9:42 AM
Closed by commit rP485933: www/chromium: Fix build on aarch64 (authored by manu). · Explain WhyNov 26 2018, 8:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51108

View Options

head/www/chromium/Makefile

Loading...
View Options

head/www/chromium/files/patch-third__party_boringssl_src_crypto_cpu-aarch64-linux.c

Loading...
View Options

head/www/chromium/files/patch-third__party_zlib_BUILD.gn

Loading...
View Options

head/www/chromium/files/patch-third__party_zlib_arm__features.c

Loading...
View Options

head/www/chromium/pkg-plist

Loading...