Implement "ipfw fwd" for incoming IPv4 packets on fast forwarding path
ClosedPublic
Actions

Authored by eugen_grosbein.net on Sep 5 2018, 5:13 AM.

Details

Reviewers

Group Reviewers

Commits

rS338611: MFC r338468: Fix "ipfw fwd" to work for incoming IPv4 packets
rS338468: Fix "ipfw fwd" to work for incoming IPv4 packets when ip_tryforward() chooses

Summary

Currently, "ipfw fwd" does not work for incoming IPv4 packets when ip_tryforward chooses fast forwarding path, but it works for IPv6 and for both on old slow path.

This change fixes this adding implementation similar to IPv6 code.

Test Plan

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231143 for test plan.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

eugen_grosbein.net created this revision.Sep 5 2018, 5:13 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 5 2018, 5:13 AM

Harbormaster completed remote builds in B19406: Diff 47683.Sep 5 2018, 5:13 AM

Same code, more context.

Harbormaster completed remote builds in B19410: Diff 47687.Sep 5 2018, 6:11 AM

eugen_grosbein.net added a reviewer: ae.Sep 5 2018, 6:11 AM

ae accepted this revision as: ae.Sep 5 2018, 10:45 AM

ae added inline comments.

sys/netinet/ip_fastfwd.c
297 ↗	(On Diff #47687)	s/ipfilter/pfil(9)/
300 ↗	(On Diff #47687)	extra parentheses

This revision is now accepted and ready to land.Sep 5 2018, 10:45 AM

Closed by commit rS338468: Fix "ipfw fwd" to work for incoming IPv4 packets when ip_tryforward() chooses (authored by eugen). · Explain WhySep 6 2018, 12:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

ip_fastfwd.c

26 lines

Diff 47725

View Options

head/sys/netinet/ip_fastfwd.c

Implement "ipfw fwd" for incoming IPv4 packets on fast forwarding pathClosedPublicActions