Page MenuHomeFreeBSD

[new port] math/libpgmath: Compiler-callable math intrinsics library
ClosedPublic

Authored by jmd on Sep 5 2018, 1:45 AM.

Details

Summary

This add libpgmath. It is the math library of the flang compiler with support for vector operations.

Patches were in large part adapted from the OpenBSD port.

Test Plan

portlint -Aac clean
poudriere tested HEAD amd64
Older releases lack support of cpuid bits needed.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jmd created this revision.Sep 5 2018, 1:45 AM
jmd updated this revision to Diff 47675.Sep 5 2018, 1:47 AM

Add check for older than 12.0

mat added a comment.Sep 5 2018, 3:14 PM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

math/libpgmath/Makefile
15 ↗(On Diff #47675)
  1. "for now" everything in the ports tree is true at the time it is committed, so remove it.
  2. "only builds" is what ONLY_FOR_ARCHS means, so, remove it.
  3. ONLY_FOR_ARCHS_REASONS_<arch> is used when <arch> is not in the supported architectures, so this one will never be used, you should remove the _amd64 bit.
37–41 ↗(On Diff #47675)

Could possibly be replaced with

IGNORE_FreeBSD_10= blah
IGNORE_FreeBSD_11= blah
math/libpgmath/pkg-descr
1 ↗(On Diff #47675)

Please provide a longer description, at least one paragraph with two lines.

jmd marked 3 inline comments as done.Sep 5 2018, 7:05 PM

Comments addressed

jmd updated this revision to Diff 47706.Sep 5 2018, 7:06 PM

Address review comments.

seanc added a subscriber: seanc.Sep 5 2018, 8:10 PM
zeising accepted this revision.Sep 6 2018, 8:02 PM

Approved

This revision is now accepted and ready to land.Sep 6 2018, 8:02 PM
This revision was automatically updated to reflect the committed changes.