Page MenuHomeFreeBSD

Remove vm_page_remque().
ClosedPublic

Authored by markj on Sep 4 2018, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 11, 9:15 PM
Unknown Object (File)
Mon, May 11, 8:26 PM
Unknown Object (File)
Thu, May 7, 6:37 AM
Unknown Object (File)
Sun, Apr 26, 4:57 AM
Unknown Object (File)
Sat, Apr 25, 6:37 PM
Unknown Object (File)
Thu, Apr 23, 10:06 PM
Unknown Object (File)
Mon, Apr 20, 6:15 PM
Unknown Object (File)
Sat, Apr 18, 2:44 PM
Subscribers

Details

Summary

See r338276. It is not sufficient to return immediately if
m->queue == PQ_NONE since another thread may be update the page's
queue state concurrently. vm_page_dequeue() now just returns if the
page is not enqueued (prior to r332974 it would panic in this case), so
simply replace all vm_page_remque() calls with vm_page_dequeue()
calls.

Test Plan

The problem was found while reading code. Peter is testing
this patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable