Page MenuHomeFreeBSD

Remove vm_page_remque().
ClosedPublic

Authored by markj on Sep 4 2018, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 2, 12:00 PM
Unknown Object (File)
Sun, Nov 30, 12:58 AM
Unknown Object (File)
Fri, Nov 28, 8:21 AM
Unknown Object (File)
Mon, Nov 24, 8:11 PM
Unknown Object (File)
Thu, Nov 20, 8:29 PM
Unknown Object (File)
Thu, Nov 20, 8:22 PM
Unknown Object (File)
Thu, Nov 20, 8:21 PM
Unknown Object (File)
Thu, Nov 20, 8:11 PM
Subscribers

Details

Summary

See r338276. It is not sufficient to return immediately if
m->queue == PQ_NONE since another thread may be update the page's
queue state concurrently. vm_page_dequeue() now just returns if the
page is not enqueued (prior to r332974 it would panic in this case), so
simply replace all vm_page_remque() calls with vm_page_dequeue()
calls.

Test Plan

The problem was found while reading code. Peter is testing
this patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable