Page MenuHomeFreeBSD

Remove vm_page_remque().
ClosedPublic

Authored by markj on Sep 4 2018, 8:03 PM.
Tags
None
Referenced Files
F172049324: D17025.id47756.diff
Tue, Sep 15, 5:58 PM
Unknown Object (File)
Tue, Sep 15, 1:44 AM
Unknown Object (File)
Mon, Sep 14, 10:19 AM
Unknown Object (File)
Mon, Sep 14, 9:23 AM
Unknown Object (File)
Mon, Sep 14, 2:29 AM
Unknown Object (File)
Sun, Sep 13, 6:36 AM
Unknown Object (File)
Tue, Sep 8, 11:34 PM
Unknown Object (File)
Tue, Sep 8, 12:11 AM
Subscribers

Details

Summary

See r338276. It is not sufficient to return immediately if
m->queue == PQ_NONE since another thread may be update the page's
queue state concurrently. vm_page_dequeue() now just returns if the
page is not enqueued (prior to r332974 it would panic in this case), so
simply replace all vm_page_remque() calls with vm_page_dequeue()
calls.

Test Plan

The problem was found while reading code. Peter is testing
this patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable