Page MenuHomeFreeBSD

Remove vm_page_remque().
ClosedPublic

Authored by markj on Sep 4 2018, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 11:20 PM
Unknown Object (File)
Mon, Oct 13, 11:20 PM
Unknown Object (File)
Mon, Oct 13, 11:20 PM
Unknown Object (File)
Mon, Oct 13, 9:43 AM
Unknown Object (File)
Sun, Oct 5, 12:50 PM
Unknown Object (File)
Sep 2 2025, 9:11 AM
Unknown Object (File)
Aug 23 2025, 1:29 PM
Unknown Object (File)
Aug 14 2025, 10:42 AM
Subscribers

Details

Summary

See r338276. It is not sufficient to return immediately if
m->queue == PQ_NONE since another thread may be update the page's
queue state concurrently. vm_page_dequeue() now just returns if the
page is not enqueued (prior to r332974 it would panic in this case), so
simply replace all vm_page_remque() calls with vm_page_dequeue()
calls.

Test Plan

The problem was found while reading code. Peter is testing
this patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable