set default rate if event description lacks one / filter sample rate for API misue
ClosedPublic
Actions

Authored by mmacy on Aug 30 2018, 8:44 PM.

Tags

None

Referenced Files

	F169435571: D16958.id47497.diff
	Tue, Sep 1, 1:12 PM

	F169378368: D16958.diff
	Tue, Sep 1, 9:05 AM

	Unknown Object (File)
	Sun, Aug 30, 12:01 PM

	Unknown Object (File)
	Sun, Aug 30, 12:00 PM

	Unknown Object (File)
	Sun, Aug 30, 9:15 AM

	Unknown Object (File)
	Sun, Aug 30, 6:41 AM

	Unknown Object (File)
	Tue, Aug 25, 9:17 PM

	Unknown Object (File)
	Mon, Aug 24, 4:42 PM

View All Files

Subscribers

gnn

imp

Details

Reviewers

markj

Commits

rS338677: hwpmc: set default rate if event description lacks one / filter rate against…

Summary

Not all event descriptions have a sample rate (such as inst_retired.any) this will restore the legacy behavior of using 65536 in that case. It also prevents accidental API misuse that could lead to panic.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230985

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mmacy created this revision.Aug 30 2018, 8:44 PM

Herald added subscribers: gnn, imp. · View Herald TranscriptAug 30 2018, 8:44 PM

Harbormaster completed remote builds in B19297: Diff 47497.Aug 30 2018, 8:44 PM

markj accepted this revision.Aug 30 2018, 8:46 PM

This revision is now accepted and ready to land.Aug 30 2018, 8:46 PM

Closed by commit rS338677: hwpmc: set default rate if event description lacks one / filter rate against… (authored by mmacy). · Explain WhySep 14 2018, 1:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libpmc/

libpmc_pmu_util.c

1 line

sys/

dev/

hwpmc/

hwpmc_mod.c

27 lines

Diff 48029

View Options

head/lib/libpmc/libpmc_pmu_util.c