mount_msdosfs(8) should not fail if kernel already has needed kiconv(3) parts
ClosedPublic
Actions

Authored by eugen_grosbein.net on Aug 30 2018, 12:11 PM.

Details

Reviewers

jkim
jh
avg
mav

Commits

rS340954: MFC r339816: mount_msdosfs
rS340953: MFC r339816: mount_msdosfs
rS340952: MFC r339816: mount_msdosfs
rS339816: mount_msdosfs: do not fail mounts requiring locale name conversion table

Summary

The command "mount_msdosfs -L ru_RU.KOI8-R" fails with error "mount_msdosfs: msdosfs_iconv: File exists" for a kernel having "options LIBICONV" and "options MSDOSFS_ICONV".

Test Plan

Use custom kernel with options noted above.
Try mouning a device using -L option.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

eugen_grosbein.net created this revision.Aug 30 2018, 12:11 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 30 2018, 12:11 PM

Harbormaster completed remote builds in B19288: Diff 47483.Aug 30 2018, 12:11 PM

eugen_grosbein.net added reviewers: avg, mav.Aug 30 2018, 12:39 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 27 2018, 4:41 PM

Closed by commit rS339816: mount_msdosfs: do not fail mounts requiring locale name conversion table (authored by eugen). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

mount_msdosfs/

mount_msdosfs.c

7 lines

Diff 49695

View Options

head/sbin/mount_msdosfs/mount_msdosfs.c

mount_msdosfs(8) should not fail if kernel already has needed kiconv(3) partsClosedPublicActions