Page MenuHomeFreeBSD
Differential D16922

Add libxo(3) support to last(1).
ClosedPublic
Actions

Authored by philip on Aug 27 2018, 4:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 10:01 PM
Unknown Object (File)
Thu, Apr 24, 2:37 AM
Unknown Object (File)
Wed, Apr 23, 2:41 PM
Unknown Object (File)
Tue, Apr 22, 5:12 PM
Unknown Object (File)
Tue, Apr 22, 5:06 PM
Unknown Object (File)
Tue, Apr 22, 2:14 PM
Unknown Object (File)
Tue, Apr 22, 1:59 PM
Unknown Object (File)
Tue, Apr 22, 1:56 PM
View All 65 Files
Subscribers
imp
kp

Details

Reviewers
kp
Group Reviewers
manpages
Commits
rS338352: Add libxo(3) support to last(1).
Summary

Adds libxo(3) support to last(1).

Test Plan
  • Diff confirms that output without --libxo is unchanged
  • Output with --libxo looks sane

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

philip created this revision.Aug 27 2018, 4:54 PM
Harbormaster completed remote builds in B19217: Diff 47351.Aug 27 2018, 4:54 PM
kp accepted this revision.Aug 28 2018, 1:14 PM
kp added a subscriber: kp.
kp added inline comments.
usr.bin/last/last.c
121 ↗(On Diff #47351)

I wonder if it's worth putting this in an atexit(3) callback. There are at least 4 calls to xo_finish() spread around the code, and it's easy to forget one, now or later if more are added.

This revision is now accepted and ready to land.Aug 28 2018, 1:14 PM
philip updated this revision to Diff 47385.Aug 28 2018, 4:34 PM
  • last: use xo_finish_atexit wrapper
This revision now requires review to proceed.Aug 28 2018, 4:34 PM
Harbormaster completed remote builds in B19239: Diff 47385.Aug 28 2018, 4:34 PM
philip marked an inline comment as done.Aug 28 2018, 4:35 PM
kp accepted this revision.Aug 28 2018, 4:42 PM
This revision is now accepted and ready to land.Aug 28 2018, 4:42 PM
Closed by commit rS338352: Add libxo(3) support to last(1). (authored by philip). · Explain WhyAug 28 2018, 5:10 PM
This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: manpages. · View Herald TranscriptAug 28 2018, 5:10 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
head/
usr.bin/
last/
1 line
16 lines
79 lines

Diff 47388

View Options

head/usr.bin/last/Makefile

Loading...
View Options

head/usr.bin/last/last.1

Loading...
View Options

head/usr.bin/last/last.c

Loading...