Page MenuHomeFreeBSD

Add libxo(3) support to last(1).
ClosedPublic

Authored by philip on Aug 27 2018, 4:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 9:18 PM
Unknown Object (File)
Oct 8 2024, 6:51 PM
Unknown Object (File)
Sep 17 2024, 3:21 PM
Unknown Object (File)
Sep 4 2024, 8:53 PM
Unknown Object (File)
Sep 2 2024, 7:50 AM
Unknown Object (File)
Aug 15 2024, 8:45 AM
Unknown Object (File)
Aug 12 2024, 8:09 PM
Unknown Object (File)
Aug 11 2024, 1:35 AM
Subscribers

Details

Reviewers
kp
Group Reviewers
manpages
Commits
rS338352: Add libxo(3) support to last(1).
Summary

Adds libxo(3) support to last(1).

Test Plan
  • Diff confirms that output without --libxo is unchanged
  • Output with --libxo looks sane

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp added a subscriber: kp.
kp added inline comments.
usr.bin/last/last.c
121 ↗(On Diff #47351)

I wonder if it's worth putting this in an atexit(3) callback. There are at least 4 calls to xo_finish() spread around the code, and it's easy to forget one, now or later if more are added.

This revision is now accepted and ready to land.Aug 28 2018, 1:14 PM
  • last: use xo_finish_atexit wrapper
This revision now requires review to proceed.Aug 28 2018, 4:34 PM
This revision is now accepted and ready to land.Aug 28 2018, 4:42 PM
This revision was automatically updated to reflect the committed changes.