Page MenuHomeFreeBSD

Add pmap_activate_boot() on i386.
ClosedPublic

Authored by kib on Aug 24 2018, 11:24 PM.
Tags
None
Referenced Files
F132387682: D16893.id47287.diff
Thu, Oct 16, 11:43 AM
F132387674: D16893.id.diff
Thu, Oct 16, 11:43 AM
F132387665: D16893.id47272.diff
Thu, Oct 16, 11:43 AM
F132387661: D16893.id47271.diff
Thu, Oct 16, 11:43 AM
F132387660: D16893.id47270.diff
Thu, Oct 16, 11:43 AM
Unknown Object (File)
Wed, Oct 15, 11:59 PM
Unknown Object (File)
Thu, Oct 9, 1:59 PM
Unknown Object (File)
Wed, Oct 8, 1:28 AM
Subscribers

Details

Summary

Move pmap_activate_boot() invocation to mp_x86.c:init_secondary_tail().
Remove dead code from i386 cpu_throw().

Suggested by: alc

Test Plan

Boot SMP i386.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove unused local label.

markj added inline comments.
sys/i386/i386/pmap.c
5810 ↗(On Diff #47271)

Extra whitespace? Looks like there's a mix of both styles in this file.

This revision is now accepted and ready to land.Aug 24 2018, 11:57 PM
kib marked an inline comment as done.Aug 25 2018, 12:13 AM
kib added inline comments.
sys/i386/i386/pmap.c
5810 ↗(On Diff #47271)

It is tab.

kib marked an inline comment as done.

Use space instead of tab.

This revision now requires review to proceed.Aug 25 2018, 12:14 AM
This revision is now accepted and ready to land.Aug 25 2018, 3:09 AM
This revision was automatically updated to reflect the committed changes.