Page MenuHomeFreeBSD
Differential D16893

Add pmap_activate_boot() on i386.
ClosedPublic
Actions

Authored by kib on Aug 24 2018, 11:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 6, 5:37 PM
Unknown Object (File)
Thu, Jan 30, 9:15 PM
Unknown Object (File)
Sun, Jan 26, 7:08 PM
Unknown Object (File)
Sun, Jan 26, 7:02 PM
Unknown Object (File)
Sun, Jan 26, 2:51 PM
Unknown Object (File)
Sun, Jan 26, 2:38 PM
Unknown Object (File)
Fri, Jan 24, 3:00 AM
Unknown Object (File)
Thu, Jan 23, 3:48 PM
View All 61 Files
Subscribers
imp
rpokala

Details

Reviewers
alc
markj
Commits
rS338313: Remove dead code in i386 cpu_throw().
rS338312: Unify amd64 and i386 vmspace0 pmap activation.
Summary

Move pmap_activate_boot() invocation to mp_x86.c:init_secondary_tail().
Remove dead code from i386 cpu_throw().

Suggested by: alc

Test Plan

Boot SMP i386.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Aug 24 2018, 11:24 PM
Herald added subscribers: rpokala, imp. · View Herald TranscriptAug 24 2018, 11:24 PM
Harbormaster completed remote builds in B19161: Diff 47270.Aug 24 2018, 11:24 PM
kib updated this revision to Diff 47271.Aug 24 2018, 11:29 PM

Remove unused local label.

Harbormaster completed remote builds in B19162: Diff 47271.Aug 24 2018, 11:29 PM
markj accepted this revision.Aug 24 2018, 11:57 PM
markj added inline comments.
sys/i386/i386/pmap.c
5810 ↗(On Diff #47271)

Extra whitespace? Looks like there's a mix of both styles in this file.

This revision is now accepted and ready to land.Aug 24 2018, 11:57 PM
kib marked an inline comment as done.Aug 25 2018, 12:13 AM
kib added inline comments.
sys/i386/i386/pmap.c
5810 ↗(On Diff #47271)

It is tab.

kib updated this revision to Diff 47272.Aug 25 2018, 12:14 AM
kib marked an inline comment as done.

Use space instead of tab.

This revision now requires review to proceed.Aug 25 2018, 12:14 AM
Harbormaster completed remote builds in B19163: Diff 47272.Aug 25 2018, 12:14 AM
alc accepted this revision.Aug 25 2018, 3:09 AM
This revision is now accepted and ready to land.Aug 25 2018, 3:09 AM
Closed by commit rS338312: Unify amd64 and i386 vmspace0 pmap activation. (authored by kib). · Explain WhyAug 25 2018, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
2 lines
i386/
i386/
16 lines
include/
1 line
x86/
x86/
3 lines

Diff 47287

View Options

head/sys/amd64/amd64/mp_machdep.c

Loading...
View Options

head/sys/i386/i386/pmap.c

Loading...
View Options

head/sys/i386/include/pmap.h

Loading...
View Options

head/sys/x86/x86/mp_x86.c

Loading...