Page MenuHomeFreeBSD

Make tcp_hpts compile with option RSS
ClosedPublic

Authored by bz on Aug 24 2018, 10:25 PM.

Details

Summary

Make tcp_hpts.c compile a LINT kernel with options RSS and PCBGROUPS added by adding the missing include files and changing a the type of cpuid which would otherwise cause a false comparison with NETISR_CPUID_NONE.

Side note:
Makes me wonder why this code uses a uint16_t rather than a uint_t we use everywhere else?

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz created this revision.Aug 24 2018, 10:25 PM
Herald added a subscriber: imp. · View Herald Transcript
bz added a reviewer: np.Aug 24 2018, 10:26 PM
rrs accepted this revision.Aug 27 2018, 2:55 PM

Because in order to conserve space the fid in the in_pcb (IIRR) is a uint16_t.. I was thinking
64k cpu's is probably enough for now :)

But I am find with the change as long as the return type does not change itself.

This revision is now accepted and ready to land.Aug 27 2018, 2:55 PM
This revision was automatically updated to reflect the committed changes.