Make tcp_hpts compile with option RSS
ClosedPublic
Actions

Authored by bz on Aug 24 2018, 10:25 PM.

Details

Reviewers

rrs
np

Group Reviewers

transport

Commits

rS338498: Make tcp_hpts.c compile a LINT kernel with options RSS and PCBGROUPS added by

Summary

Make tcp_hpts.c compile a LINT kernel with options RSS and PCBGROUPS added by adding the missing include files and changing a the type of cpuid which would otherwise cause a false comparison with NETISR_CPUID_NONE.

Side note:
Makes me wonder why this code uses a uint16_t rather than a uint_t we use everywhere else?

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Aug 24 2018, 10:25 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptAug 24 2018, 10:25 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B19159: Diff 47268.Aug 24 2018, 10:25 PM

bz added a reviewer: np.Aug 24 2018, 10:26 PM

Because in order to conserve space the fid in the in_pcb (IIRR) is a uint16_t.. I was thinking
64k cpu's is probably enough for now :)

But I am find with the change as long as the return type does not change itself.

This revision is now accepted and ready to land.Aug 27 2018, 2:55 PM

Closed by commit rS338498: Make tcp_hpts.c compile a LINT kernel with options RSS and PCBGROUPS added by (authored by bz). · Explain WhySep 6 2018, 4:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_hpts.c

4 lines

Diff 47754

View Options

head/sys/netinet/tcp_hpts.c

Make tcp_hpts compile with option RSSClosedPublicActions