Paths

Table of Contentst

Differential D16854

multimedia/gxine: Fixed PLIST issue; Change on/off options
AbandonedPublic
Actions

Authored by ndowens_yahoo.com on Aug 22 2018, 11:09 PM.

Tags

None

Referenced Files

	F115546797: D16854.diff
	Fri, Apr 25, 4:02 AM

	Unknown Object (File)
	Wed, Apr 9, 4:35 AM

	Unknown Object (File)
	Thu, Mar 27, 3:45 AM

	Unknown Object (File)
	Feb 28 2025, 4:18 PM

	Unknown Object (File)
	Feb 23 2025, 7:37 PM

	Unknown Object (File)
	Feb 23 2025, 2:04 PM

	Unknown Object (File)
	Feb 20 2025, 1:16 AM

	Unknown Object (File)
	Jan 27 2025, 9:06 AM

View All 70 Files

Subscribers

Contributor Reviewers (ports)

Details

Reviewers: None

Summary

Fixed packaging issue due to plist issue
Used with/enable instead of on/off when possible
Added License file while here

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 19089
Build 18717: arc lint + arc unit

Event Timeline

ndowens_yahoo.com created this revision.Aug 22 2018, 11:09 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptAug 22 2018, 11:09 PM

Harbormaster completed remote builds in B19075: Diff 47141.Aug 22 2018, 11:09 PM

ndowens_yahoo.com added inline comments.Aug 22 2018, 11:32 PM

multimedia/gxine/Makefile
31	This is no longer available in ports, and gxine works without it

ndowens_yahoo.com edited the summary of this revision. (Show Details)Aug 22 2018, 11:33 PM

mat added inline comments.Aug 23 2018, 7:05 AM

multimedia/gxine/Makefile
6	Why go from 0 to 2? 1 was not good enough?
35	Remove `--without-dbus`, it is already present in the previous line. As for the other one, it should probably be using `*_CONFIGURE_ENABLE`.
42–43	Remove this.
42–45	Remove the .if/.endif, leave the content.
55–56	Never ever install files with `CP`, use one of the `INSTALL_*` macros.
56–60	post-install-WEBPLUGIN-on:

ndowens_yahoo.com marked 6 inline comments as done.Aug 23 2018, 11:08 AM

Updating D16854: multimedia/gxine: Fixed PLIST issue; Change on/off options
Updated with mat's suggestions

Harbormaster completed remote builds in B19089: Diff 47159.Aug 23 2018, 11:12 AM

tobik mentioned this in D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken.Aug 30 2018, 7:53 AM

ndowens_yahoo.com abandoned this revision.Aug 31 2018, 3:56 AM

Revision Contents
Changeset List

Path

Size

multimedia/

gxine/

41 lines

1 line

Diff 47159

multimedia/gxine/Makefile

Loading...

multimedia/gxine/pkg-plist

Loading...