Eliminate the unused arena parameter from kmem_alloc_attr()

[alc]

Summary

The title says it all.

[alc]

This should probably include an increment to __FreeBSD_version.

[alc]

I'm happy to either add kmem_malloc() and kmem_alloc_contig() to this patch or do them separately.

[kib]

kmem_malloc() needs sys_machdep.c update. I think it is better to keep them in separate changes.

[markj]

dev/drm2/drm_scatter.c

40 ↗

(On Diff #46902)

Fix style while here?

[alc]

In D16793#357198, @kib wrote:

kmem_malloc() needs sys_machdep.c update. I think it is better to keep them in separate changes.

Okay. I'm happy with that.

Should I bump __FreeBSD_version?

[kib]

In D16793#357203, @alc wrote:

Should I bump __FreeBSD_version?

I would not.

dev/drm2/drm_scatter.c

40 ↗

(On Diff #46902)

This is almost contrib code. Also it is almost dead.

[alc]

In D16793#357204, @kib wrote:

In D16793#357203, @alc wrote:

Should I bump __FreeBSD_version?

I would not.

Could you please elaborate? This is going to impact out-of-tree drivers, e.g., Virtual Box and the newer drm, right? Are you suggesting that I never bump __FreeBSD_version, or wait until all of the kmem functions are "fixed"?

[kib]

In D16793#357232, @alc wrote:

In D16793#357204, @kib wrote:

In D16793#357203, @alc wrote:

Should I bump __FreeBSD_version?

I would not.

Could you please elaborate? This is going to impact out-of-tree drivers, e.g., Virtual Box and the newer drm, right? Are you suggesting that I never bump __FreeBSD_version, or wait until all of the kmem functions are "fixed"?

My personal opinion that drivers for HEAD should follow the KPI of the tip of the HEAD and not introduce ifdefs. Practically, trying to present the KPI and KBI history as the monotonic single __FreeBSD_version value does not work anyway.