Page MenuHomeFreeBSD

sysutils/xosview: unbreak in 12
ClosedPublic

Authored by fernape on Aug 16 2018, 4:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 9:02 AM
Unknown Object (File)
Fri, Jan 10, 5:00 AM
Unknown Object (File)
Dec 8 2024, 5:50 PM
Unknown Object (File)
Dec 4 2024, 10:14 AM
Unknown Object (File)
Dec 4 2024, 1:18 AM
Unknown Object (File)
Nov 14 2024, 3:50 AM
Unknown Object (File)
Nov 1 2024, 5:18 AM
Unknown Object (File)
Nov 1 2024, 3:04 AM
Subscribers

Details

Summary

Broken due to changes in sys/vmmeter.h

https://github.com/hills/xosview/pull/11 to upstream project

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • run test in 11.2 OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Good job, working on that :)

I would use the contents of
https://github.com/hills/xosview/commit/0b4861c9fed2dc8450edf2dff7988ebd784a520b.patch
as the patch file (you only need to fix the git-prefix stuff) -- if it applies :) -- otherwise, I would inclulde the link to the pull request at the top of the patch.

If the git-patch works, you could also name it something like patch-git_0b4861c -- that way its obvious that the patch is most likely a temporary thing.

Add git pull request link to the patch.

Good job, working on that :)

I would use the contents of
https://github.com/hills/xosview/commit/0b4861c9fed2dc8450edf2dff7988ebd784a520b.patch
as the patch file (you only need to fix the git-prefix stuff) -- if it applies :) -- otherwise, I would inclulde the link to the pull request at the top of the patch.

If the git-patch works, you could also name it something like patch-git_0b4861c -- that way its obvious that the patch is most likely a temporary thing.

I tried but it doesn't seem to work. After fixing the git-prefix by removing a/ and b/ sutff, the patch finds the proper file to patch but fails to apply the changes. I think the reason is that patch-bsd_kernel.cc is applied first and it adds three lines above the changes in the git-patch. This somehow confuses patch (probably for the better).

I added the link to the pull request instead.

Good job, working on that :)

I would use the contents of
https://github.com/hills/xosview/commit/0b4861c9fed2dc8450edf2dff7988ebd784a520b.patch
as the patch file (you only need to fix the git-prefix stuff) -- if it applies :) -- otherwise, I would inclulde the link to the pull request at the top of the patch.

If the git-patch works, you could also name it something like patch-git_0b4861c -- that way its obvious that the patch is most likely a temporary thing.

I tried but it doesn't seem to work. After fixing the git-prefix by removing a/ and b/ sutff, the patch finds the proper file to patch but fails to apply the changes. I think the reason is that patch-bsd_kernel.cc is applied first and it adds three lines above the changes in the git-patch. This somehow confuses patch (probably for the better).

I added the link to the pull request instead.

yeah sorry, I overlooke d that the patch wasn't completely new :)

This revision is now accepted and ready to land.Aug 24 2018, 6:10 PM
This revision was automatically updated to reflect the committed changes.