Page MenuHomeFreeBSD

devel/boehm-gc: update to 7.6.8 * Bump PORTREVISION for dependent ports.
ClosedPublic

Authored by fernape on Aug 13 2018, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 1:22 PM
Unknown Object (File)
Fri, Nov 22, 6:38 PM
Unknown Object (File)
Fri, Nov 22, 6:37 PM
Unknown Object (File)
Fri, Nov 22, 6:37 PM
Unknown Object (File)
Fri, Nov 22, 6:36 PM
Unknown Object (File)
Fri, Nov 22, 6:36 PM
Unknown Object (File)
Fri, Nov 22, 6:34 PM
Unknown Object (File)
Fri, Nov 22, 6:14 PM
Subscribers

Details

Summary

Via PR 230577

Submitter requests maintainership

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 11.2amd64, 12i386 OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Is this snippet valid?

.if ${PORT_OPTIONS:MDEBUG}
CONFIGURE_ARGS+=--enable-gc-debug
PKGNAMESUFFIX:= ${PKGNAMESUFFIX}+fulldebug
.endif

According to the handbook a port must not change its name when its option set changes.

I don't think the version bumps are required -- or did the so-ver change?

Is this snippet valid?

.if ${PORT_OPTIONS:MDEBUG}
CONFIGURE_ARGS+=--enable-gc-debug
PKGNAMESUFFIX:= ${PKGNAMESUFFIX}+fulldebug
.endif

According to the handbook a port must not change its name when its option set changes.

It is valid, but it is wrong, it should not change its PKGNAMESUFFIX.

I don't think the version bumps are required -- or did the so-ver change?

They changed. From 1.3.0 -> 1.3.1, 1.3.1 -> 1.32, 1.3.3 -> 1.3.4

Remove change of PKGNAMESUFFIX

Also simplify option handling.

Updating D16704: devel/boehm-gc: update to 7.6.8

  • Bump PORTREVISION for dependent ports.

Adding depending ports to the review.

devel/boehm-gc/Makefile
69 ↗(On Diff #46722)

^ is that still required?

Removing unnecessary include from Makefile

Updating D16704: devel/boehm-gc: update to 7.6.8

  • Bump PORTREVISION for dependent ports.
fernape added inline comments.
devel/boehm-gc/Makefile
69 ↗(On Diff #46722)

It seems it's not.

Looks good to me.

devel/boehm-gc/Makefile
56 ↗(On Diff #47246)

while you're here, you could add "\t" after all the "=" where there are none.

This revision is now accepted and ready to land.Aug 31 2018, 11:06 AM
This revision was automatically updated to reflect the committed changes.