Page MenuHomeFreeBSD
Differential D16697

Extend path completion by shell info in porters handbook.
ClosedPublic
Actions

Authored by sevan on Aug 12 2018, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 2:17 PM
Unknown Object (File)
Fri, Dec 20, 1:41 AM
Unknown Object (File)
Nov 25 2024, 2:40 PM
Unknown Object (File)
Nov 14 2024, 9:29 PM
Unknown Object (File)
Nov 14 2024, 1:28 AM
Unknown Object (File)
Oct 5 2024, 7:35 PM
Unknown Object (File)
Oct 4 2024, 11:30 PM
Unknown Object (File)
Oct 3 2024, 2:00 AM
View All 46 Files
Subscribers
carlavilla
linimon

Details

Reviewers
bcr
mat
0mp
Group Reviewers
Doc Committers
Commits
R9:266aa8a0eae5: Porter's handbook: Added and clarified full path names
Summary

bug 225008 by yuri@
Add Fish example
Add another location used by Bash
Add the filename used by ZSH.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sevan created this revision.Aug 12 2018, 6:16 PM
Herald added a reviewer: mat. · View Herald TranscriptAug 12 2018, 6:16 PM
Harbormaster completed remote builds in B18751: Diff 46605.Aug 12 2018, 6:16 PM
mat added inline comments.Aug 13 2018, 12:02 PM
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
5835 ↗(On Diff #46605)

If you want to use of, it needs to be written Path of shell completion files or something similar. I would just keep this as it was.

5841 ↗(On Diff #46605)

There should only be one directory here, so that committers do not choose randomly where to put the files.

Looking at the bash_completion code, it looks like etc/bash_completion.d is for legacy scripts, and share/bash-completion/completions is for recent scripts.

5842 ↗(On Diff #46605)

It would be preferable to say something specific, or to not say anything.

linimon added a subscriber: linimon.Aug 14 2018, 2:01 AM
sevan updated this revision to Diff 46652.Aug 14 2018, 8:20 AM

Don't reword the title, it was ok to begin with.
Switch bash location from legacy to current path.
Drop superfluous sentence.

Harbormaster completed remote builds in B18784: Diff 46652.Aug 14 2018, 8:20 AM
sevan marked 3 inline comments as done.Aug 14 2018, 8:23 AM

updated

mat accepted this revision.Aug 14 2018, 10:38 AM
This revision is now accepted and ready to land.Aug 14 2018, 10:38 AM
mat added a comment.Aug 14 2018, 10:39 AM

I have been wondering though, PORTNAME seems wrong in there, shouldn't it be command-name instead?

0mp accepted this revision.Aug 16 2018, 5:10 PM
linimon added a comment.Jan 5 2020, 10:42 PM

Is there any reason that this should not be committed at this point?

sevan added a comment.Jan 6 2020, 12:07 AM
In D16697#505077, @linimon wrote:

Is there any reason that this should not be committed at this point?

I'm unable to answer Mat's last question.

carlavilla added a subscriber: carlavilla.Mar 26 2023, 2:03 PM

I'm gonna convert this to AsciiDoc and make the change.
Thanks!

carlavilla added a comment.Apr 4 2023, 6:04 PM

@mat can I commit this patch?

Closed by commit R9:266aa8a0eae5: Porter's handbook: Added and clarified full path names (authored by carlavilla). · Explain WhyAug 29 2023, 7:30 PM
This revision was automatically updated to reflect the committed changes.
carlavilla added a commit: R9:266aa8a0eae5: Porter's handbook: Added and clarified full path names.

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
books/
porters-handbook/
special/
13 lines

Diff 126659

View Options

documentation/content/en/books/porters-handbook/special/_index.adoc

Loading...