Page MenuHomeFreeBSD

make arm64 identcpu use an sbuf
ClosedPublic

Authored by jmg on Aug 12 2018, 2:57 AM.

Details

Summary

On my A64-LTS, I get interleaved output w/ other console messages, using an sbuf
will ensure that lines are printed together, and not intermixed...

Previously:

CPU  0: ARM Cortex-A53 r0p4mmc0: Trying to mount root from ufs:/dev/ufs/rootfs [rw]...
 affinity:ACMD42 failed, RESULT: 4
  0mmc0: 
 Instruction Set Attributes 0 = <Card at relative address 43690 failed to set bus width
AES+PMULL,SHA1,SHA2,CRC32>

After:

CPU  0: ARM Cortex-A53 r0p4 affinity:  0
Trying to mount root from ufs:/dev/ufs/rootfs [rw]...
mmc0:  Instruction Set Attributes 0 = <AES+PMULL,SHA1,SHA2,CRC32>
ACMD42 failed, RESULT: 4

Notice how affinity: 0, and the attributes are now all on the same line, where previously
they had other console messages in the middle of them.

the mmc0: broken lines are due to device_printf not using sbuf, and I will create another rev w/ that change.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jmg created this revision.Aug 12 2018, 2:57 AM
jmg edited the summary of this revision. (Show Details)Aug 12 2018, 2:59 AM
manu accepted this revision.Aug 12 2018, 4:43 AM

LGTM

This revision is now accepted and ready to land.Aug 12 2018, 4:43 AM
This revision was automatically updated to reflect the committed changes.