graphics/partio: update to 1.5.5

[fernape]

Summary

Update port to 1.5.5 (reported by portscout).

• Fix BINARY_ALIAS (only needed if python is selected)

I don't know how to deal with the shebangfix problem. I fixed it by using python2.7 and then using python_CMD pointing to that interpreter but I don't know if this is the best thing to do. How to know which interpreter is installed?

Test Plan

• portlint -AC OK
• poudriere builds for {10.4,11.1}{amd64,i386}, 11.2amd64, 12i386 OK

[tcberner]

graphics/partio/Makefile

32

^the list of files is relative to ${WRKSRC}, so you can make the lines shorter

[mat]

graphics/partio/Makefile

24

Per policy, DOCS cannot bring doxygen in, you should add a DOXYGEN option with a DOXYGEN_IMPLIES=DOCS.

28

This is already set by USES=shebangfix, not needed.

[fernape]

• Remove ${WRKSRC} from PYTHON_BINARY_ALIAS
• Remove python_CMD
• Update to 1.5.4

[fernape]

catch up with upstream: update to 1.5.5

[tcberner]

You still need to address the DOCS changes requested by mat.

[fernape]

In D16662#359378, @tcberner wrote:

You still need to address the DOCS changes requested by mat.

I completely missed that comment. Thanks!

[fernape]

Add DOXYGEN option instead of DOCS.

This avoids breaking policy of not pulling doxygen as a dependency
directly from DOCS.

[mat]

graphics/partio/Makefile

21

You are missing the DOCS option here.

[fernape]

graphics/partio/Makefile

21

Hi mat!

I did it mimicking audio/chromaprint.

The doc target in partio's src/doc CMakeLists.txt only runs doxygen, and nothing else. What is the reason to have both DOCS and DOXYGEN as options? If DOCS is always on by default, and the user doesn't select DOXYGEN, which is the only one pulling devel/doxygen, it won't work.

Sorry if I'm missing something here :-)

[mat]

graphics/partio/Makefile

21

You are using PORTDOCS. PORTDOCS is only used when there is a DOCS option is BOTH defined, AND enabled.
Right now, setting the DOXYGEN option does only one thing, bring in all of doxygen dependencies, build the doc, and trash them after the package is created.

[fernape]

Fixing DOCS option handling.

• Added a post-install-DOCS-on target that copies tutorial and manual
• Added a post-patch-{DOCS,DOXYGEN}-off target that disables the doc subdirectory addition in the CMakeLists.txt

I don't like duplicating the logic of post-patch-{DOCS,DOXYGEN}-off. Is it preferred to add a normal .if?

Testing:

make package and then pkg info -l -F partio-1.5.5.txz  | less

DOCS: off
DOXYGEN: off

No tutorial, manual or html present in the package

DOCS: on
DOXYGEN: off

tutorial and manual in the package. No html files from doxygen generated

DOCS: off
DOXYGEN: on

tutorial and manual in the package. html files from doxygen present in the package

DOCS: on
DOXYGEN: on

tutorial and manual in the package. html files from doxygen present in the package

[mat]

In D16662#361023, @fernape wrote:

I don't like duplicating the logic of post-patch-{DOCS,DOXYGEN}-off. Is it preferred to add a normal .if?

You don't need to have a post-patch-DOXYGEN-off, only the post-patch-DOCS-off one is required. Because DOXYGEN_IMPLIES=DOCS.

DOCS: off
DOXYGEN: on

You cannot have DOCS disabled if DOXYGEN is enabled. Because DOXYGEN_IMPLIES=DOCS.

[fernape]

Remove post-patch-DOXYGEN-off.

[fernape]

In D16662#361092, @mat wrote:

In D16662#361023, @fernape wrote:

I don't like duplicating the logic of post-patch-{DOCS,DOXYGEN}-off. Is it preferred to add a normal .if?

You don't need to have a post-patch-DOXYGEN-off, only the post-patch-DOCS-off one is required. Because DOXYGEN_IMPLIES=DOCS.

DOCS: off
DOXYGEN: on

You cannot have DOCS disabled if DOXYGEN is enabled. Because DOXYGEN_IMPLIES=DOCS.

Sorry, I mean during configure I can select DOXYGEN and not DOCS, but yes, the built package is DOCS:on and DOXYGEN:on

[mat]

In D16662#361128, @fernape wrote:

In D16662#361092, @mat wrote:

In D16662#361023, @fernape wrote:

DOCS: off
DOXYGEN: on

You cannot have DOCS disabled if DOXYGEN is enabled. Because DOXYGEN_IMPLIES=DOCS.

Sorry, I mean during configure I can select DOXYGEN and not DOCS, but yes, the built package is DOCS:on and DOXYGEN:on

Yes, you can, but it does not gets disabled because DOXYGEN is enabled.

[mat]

graphics/partio/Makefile

53–54

This could probably be remplaced with:

DOXYGEN_ALL_TARGET= all doc

[fernape]

Simplify doxygen files generation.

[tcberner]

Looks good to me, as long as @mat is happy with the option handling now :)

[fernape]

Updated by @danfe in r479514

[danfe]

Whoops, sorry, I didn't know you've been working on an update. DOXYGEN option is still missing though.

[fernape]

In D16662#365037, @danfe wrote:

Whoops, sorry, I didn't know you've been working on an update. DOXYGEN option is still missing though.

No worries! I might create a new review to add that at some point :-)