Differential D16420

Fastpath was a temp holder to give as an example and now needs to disappear
ClosedPublic
Actions

Authored by rrs on Jul 24 2018, 1:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 22, 9:19 AM

	Unknown Object (File)
	Sun, Dec 22, 9:14 AM

	Unknown Object (File)
	Dec 12 2024, 6:15 PM

	Unknown Object (File)
	Dec 3 2024, 12:40 AM

	Unknown Object (File)
	Nov 23 2024, 5:00 AM

	Unknown Object (File)
	Nov 20 2024, 2:10 AM

	Unknown Object (File)
	Nov 20 2024, 1:36 AM

	Unknown Object (File)
	Sep 27 2024, 11:28 PM

View All 52 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS336672: Delete the example tcp stack "fastpath" which

Summary

The fastpath.c was a hack I originally threw together that changed a minor fastpath idea (i.e. you can stay in the fastpath with a rwnd update). This
was meant to be mainly an example of how new stacks can appear. With the addition of rack.c we no longer need this
(the actual fastpath idea is incorporated in rack anyway).

Test Plan

Validate that when I build with added-stacks it does not appear any more

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rrs created this revision.Jul 24 2018, 1:22 PM

rrs updated this revision to Diff 45774.Jul 24 2018, 1:27 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptJul 24 2018, 1:27 PM

It looks like you're keeping the code by moving it to the modules directory? At this point, I think it just makes sense to delete it.

This revision now requires changes to proceed.Jul 24 2018, 1:39 PM

Never mind. It looks like this is a display issue, and you really are deleting them.

This revision is now accepted and ready to land.Jul 24 2018, 2:18 PM

Closed by commit rS336672: Delete the example tcp stack "fastpath" which (authored by rrs). · Explain WhyJul 24 2018, 2:56 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJul 24 2018, 2:56 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

modules/

tcp/

2 lines

fastpath/

18 lines

netinet/

tcp_stacks/

2360 lines

Diff 45779

head/sys/modules/tcp/Makefile

Loading...

head/sys/modules/tcp/fastpath/Makefile

Loading...

head/sys/netinet/tcp_stacks/fastpath.c

Loading...