Page MenuHomeFreeBSD
Differential D1638

Add witness warning to callout_drain()
ClosedPublic
Actions

Authored by adrian on Jan 24 2015, 10:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 8 2024, 3:24 AM
Unknown Object (File)
Oct 3 2024, 12:49 AM
Unknown Object (File)
Sep 29 2024, 4:35 AM
Unknown Object (File)
Sep 29 2024, 4:35 AM
Unknown Object (File)
Sep 29 2024, 4:24 AM
Unknown Object (File)
Sep 25 2024, 5:32 PM
Unknown Object (File)
Sep 25 2024, 12:17 AM
Unknown Object (File)
Sep 24 2024, 6:55 AM
View All 34 Files
Subscribers
emaste
• hselasky
imp

Details

Reviewers
jhb
• hselasky
Summary

Right now there's no witness warning to the callout_drain() routine.
This tripped me whilst debugging the way ath(4) was using callouts.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

adrian updated this revision to Diff 3391.Jan 24 2015, 10:17 PM
adrian retitled this revision from to Add witness warning to callout_drain().
adrian updated this object.
adrian edited the test plan for this revision. (Show Details)
adrian added a reviewer: jhb.
• hselasky added a subscriber: • hselasky.Jan 25 2015, 7:46 AM

I think this is a good idea. D1438 also adds such an assert.
Note that "c->c_lock" can be NULL. Else no further comments.

adrian added a comment.Jan 25 2015, 8:06 AM

witness_warn() is ok with lock being NULL - it's the only lock that's currently allowed to be held during sleep. So it's fine to be NULL.

jhb accepted this revision.Jan 25 2015, 8:21 PM
jhb edited edge metadata.

You could probably drop the extra braces, but that is a minor nit.

This revision is now accepted and ready to land.Jan 25 2015, 8:21 PM
emaste added a subscriber: emaste.Nov 15 2018, 9:05 PM

Ready to commit?

Herald added a subscriber: imp. · View Herald TranscriptNov 15 2018, 9:05 PM
• hselasky accepted this revision.Nov 16 2018, 9:26 AM
• hselasky added a comment.May 18 2021, 2:22 PM

Ping - was this submitted?

jhb added a comment.May 18 2021, 4:35 PM

I don't think it was, but it should be. You can use adrian as the commit author.

adrian added a comment.May 18 2021, 4:40 PM

lol! this is old!

want me to go and land this today?

adrian added a comment.May 18 2021, 5:18 PM

Nah, this already landed a long long time ago.

9500dd9f0bbf

adrian closed this revision.May 18 2021, 5:18 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
5 lines

Diff 3391

View Options

sys/kern/kern_timeout.c

Loading...