spigen
ClosedPublic
Actions

Authored by lwhsu on Jul 20 2018, 5:40 PM.

Details

Reviewers

gonzo
• ian

Commits

rS336561: Fix `make` in sys/modules/spigen

Summary

~/freebsd-src/sys/modules/spigen $ make
machine -> /usr/home/lwhsu/freebsd-src/sys/amd64/include
x86 -> /usr/home/lwhsu/freebsd-src/sys/x86/include
awk -f /usr/home/lwhsu/freebsd-src/sys/tools/makeobjops.awk /usr/home/lwhsu/freebsd-src/sys/kern/bus_if.m -h
awk -f /usr/home/lwhsu/freebsd-src/sys/tools/makeobjops.awk /usr/home/lwhsu/freebsd-src/sys/kern/device_if.m -h
:> opt_platform.h
awk -f /usr/home/lwhsu/freebsd-src/sys/tools/makeobjops.awk /usr/home/lwhsu/freebsd-src/sys/dev/spibus/spibus_if.m -h
cc  -O2 -pipe -march=native  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -I. -I/usr/home/lwhsu/freebsd-src/sys -I/usr/home/lwhsu/freebsd-src/sys/contrib/ck/include -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer   -MD  -MF.depend.spigen.o -MTspigen.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member  -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/home/lwhsu/freebsd-src/sys/dev/spibus/spigen.c -o spigen.o
/usr/home/lwhsu/freebsd-src/sys/dev/spibus/spigen.c:29:10: fatal error: 'opt_spi.h' file not found
#include "opt_spi.h"
         ^~~~~~~~~~~
1 error generated.
*** Error code 1

Stop.
make: stopped in /usr/home/lwhsu/freebsd-src/sys/modules/spigen

Test Plan

cd sys/modules/spigen && make

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18210
Build 17942: arc lint + arc unit

Event Timeline

lwhsu created this revision.Jul 20 2018, 5:40 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 20 2018, 5:40 PM

Harbormaster completed remote builds in B18210: Diff 45619.Jul 20 2018, 5:40 PM

Oops, my bad, sorry about that. IMO, you should probably just commit changes like this without slowing down with a phab review.

This revision is now accepted and ready to land.Jul 20 2018, 5:44 PM

Closed by commit rS336561: Fix `make` in sys/modules/spigen (authored by lwhsu). · Explain WhyJul 20 2018, 5:47 PM

This revision was automatically updated to reflect the committed changes.

In D16368#347494, @ian wrote:

Oops, my bad, sorry about that. IMO, you should probably just commit changes like this without slowing down with a phab review.

Never mind, just came across this when doing other tests. I think I will just commit this kind of change after having src bit.

Revision Contents
Changeset List

Path

Size

sys/

modules/

spigen/

Makefile

1 line

Diff 45619

View Options

sys/modules/spigen/Makefile

Fix `make` in sys/modules/spigenClosedPublicActions