graphics/opencollada: update to 1.6.63
ClosedPublic
Actions

Authored by fernape on Jul 19 2018, 8:31 PM.

Details

Reviewers

tcberner
tz

Commits

rP475100: graphics/opencollada: update to 1.6.63

Summary

Update graphics/opencollada and bump PORTREVISION for dependant ports:

editors/libreoffice
graphics/blender

The deleted patch has been integrated upstream.

Test Plan

portlint -AC OK
poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
poudriere build for graphics/blender (dependant port) OK in 10.4 amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 18180
Build 17913: arc lint + arc unit

Event Timeline

fernape created this revision.Jul 19 2018, 8:31 PM

Herald added a subscriber: mat. · View Herald TranscriptJul 19 2018, 8:31 PM

Harbormaster completed remote builds in B18177: Diff 45558.Jul 19 2018, 8:31 PM

fernape edited the summary of this revision. (Show Details)Jul 19 2018, 8:32 PM

tcberner added inline comments.Jul 19 2018, 8:37 PM

graphics/opencollada/Makefile
25–26	you could write this nicer as (if you want) CMAKE_ON=USE_SHARED CMAKE_OFF= USE_STATIC

Change CMAKE_ARGS for CMAKE_ON/OFF

Harbormaster completed remote builds in B18180: Diff 45561.Jul 19 2018, 8:57 PM

fernape marked an inline comment as done.Jul 19 2018, 9:00 PM

fernape added inline comments.

graphics/opencollada/Makefile
25–26	Yep, looks tidy :-)

Why bump dependent ports?

In D16353#347350, @mat wrote:

Why bump dependent ports?

editors/libreoffice depends on libGeneratedSaxParser.so that is installed by graphics/opencollada... but since I notice the installed library is not versioned, maybe this is not necessary?

In D16353#347431, @fernape wrote:

In D16353#347350, @mat wrote:

Why bump dependent ports?

editors/libreoffice depends on libGeneratedSaxParser.so that is installed by graphics/opencollada... but since I notice the installed library is not versioned, maybe this is not necessary?