Get rid of unused variables.
ClosedPublic
Actions

Authored by delphij on Jul 18 2018, 3:09 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 28, 12:36 PM

	Unknown Object (File)
	Fri, Aug 21, 4:32 PM

	Unknown Object (File)
	Fri, Aug 21, 2:56 PM

	Unknown Object (File)
	Wed, Aug 19, 1:31 PM

	Unknown Object (File)
	Fri, Aug 14, 6:54 PM

	Unknown Object (File)
	Fri, Aug 14, 6:52 PM

	Unknown Object (File)
	Fri, Aug 14, 6:50 PM

	Unknown Object (File)
	Jul 29 2026, 8:23 PM

View All Files

Subscribers

imp

Details

Reviewers

markm
pfg
cem

Commits

rS336540: Get rid of unused variables.

Summary

Get rid of unused variables.

copied_key and copied_salt are assigned with NULL and never used
otherwise. Remove the two variables and related code.

Test Plan

Run built-in test cases found in the source

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij created this revision.Jul 18 2018, 3:09 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 18 2018, 3:09 AM

Harbormaster completed remote builds in B18112: Diff 45443.Jul 18 2018, 3:09 AM

Why would I review your changes after your disrespectful personal attacks earlier?

Good catch!

This revision is now accepted and ready to land.Jul 18 2018, 3:51 AM

Closed by commit rS336540: Get rid of unused variables. (authored by delphij). · Explain WhyJul 20 2018, 7:07 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libcrypt/

crypt-sha256.c

9 lines

crypt-sha512.c

9 lines

Diff 45585

View Options

head/lib/libcrypt/crypt-sha256.c