Page MenuHomeFreeBSD
Differential D16288

Improve TCP related dtrace tests
ClosedPublic
Actions

Authored by tuexen on Jul 16 2018, 2:30 PM.
Tags
None
Referenced Files
F133041907: D16288.id.diff
Wed, Oct 22, 9:16 AM
F133041903: D16288.id45675.diff
Wed, Oct 22, 9:16 AM
F133041902: D16288.id45368.diff
Wed, Oct 22, 9:16 AM
F133041900: D16288.id45628.diff
Wed, Oct 22, 9:16 AM
Unknown Object (File)
Tue, Oct 21, 8:50 PM
Unknown Object (File)
Wed, Oct 15, 4:31 AM
Unknown Object (File)
Tue, Oct 14, 2:19 AM
Unknown Object (File)
Sun, Oct 5, 11:33 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
gnn
Commits
rS336597: Improve TCP related tests for dtrace.
Summary

Ensure the TCP dtrace tests use graceful terminated TCP connections. Furthermore, use appropriate numbers for sent/received packet.
These tests expose some dtrace related bugs in the TCP code which are fixed in D16369.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 18215

Event Timeline

tuexen created this revision.Jul 16 2018, 2:30 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 16 2018, 2:30 PM
Harbormaster completed remote builds in B18069: Diff 45368.Jul 16 2018, 2:30 PM
tuexen added a reviewer: markj.Jul 16 2018, 2:31 PM
tuexen updated this revision to Diff 45628.Jul 20 2018, 8:22 PM

Enable tst.localtcpstate.ksh, since it passes now.

Herald added a reviewer: gnn. · View Herald TranscriptJul 20 2018, 8:22 PM
Harbormaster completed remote builds in B18215: Diff 45628.Jul 20 2018, 8:22 PM
tuexen edited the summary of this revision. (Show Details)Jul 20 2018, 8:24 PM
markj accepted this revision.Jul 21 2018, 7:04 PM

Nice, thank you.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 22 2018, 10:51 AM
Closed by commit rS336597: Improve TCP related tests for dtrace. (authored by tuexen). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
cmd/
dtrace/
test/
tst/
common/
ip/
21 lines
20 lines
20 lines
19 lines
usr.sbin/
dtrace/
tests/
tools/
3 lines

Diff 45628

View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv4localtcp.ksh

Loading...
View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv4remotetcp.ksh

Loading...
View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.localtcpstate.ksh

Loading...
View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.remotetcpstate.ksh

Loading...
View Options

cddl/usr.sbin/dtrace/tests/tools/exclude.sh

Loading...