Page MenuHomeFreeBSD

Disable sbrk() use in GNU tools.
ClosedPublic

Authored by brooks on Jul 5 2018, 2:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 5:50 AM
Unknown Object (File)
Feb 1 2024, 10:09 AM
Unknown Object (File)
Jan 31 2024, 3:55 PM
Unknown Object (File)
Jan 9 2024, 8:34 AM
Unknown Object (File)
Dec 20 2023, 3:34 AM
Unknown Object (File)
Dec 16 2023, 9:07 PM
Unknown Object (File)
Nov 26 2023, 2:08 PM
Unknown Object (File)
Sep 28 2023, 2:31 AM
Subscribers

Details

Summary

We'd like to remove sbrk() eventually so we should stop depending on it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gnu/usr.bin/binutils/as/config.h
72 ↗(On Diff #44905)

Should be /* #undef HAVE_SBRK */ for consistency with the other not-defined ones?

gnu/usr.bin/binutils/as/config.h
72 ↗(On Diff #44905)

That would be more consistent, but all of these are generated files that will never be regenerated and are on the chopping block already.

Although we still need to make sure that everything still works with this change.

Although we still need to make sure that everything still works with this change.

I'll fire off a tinderbox run which should exercise . Do you think this warrants an exp-run as well?

I doubt an exp-run is necessary, as only three binutils are built today, as, ld, objdump (on some subset of architectures), and if anything does break I expect it would most likely be found by tinderbox.

This revision is now accepted and ready to land.Jul 5 2018, 4:18 PM

I'm running a tinderbox on ref12-aarch64 with this and an unrelated patch to binutils to test cross building from arm64.

I've finally done a tinderbox run on this with make tinderbox UNIVERSE_TARGET=toolchain JFLAG=-j16. All targets built and compiled things so I think we're ready to go.

  • Rebase
  • Add /* #undef HAVE_SBRK */ comments.
This revision now requires review to proceed.Sep 18 2018, 10:02 PM
This revision is now accepted and ready to land.Sep 19 2018, 8:37 AM
This revision was automatically updated to reflect the committed changes.