Drop builtin float.h for amd64-gcc.
ClosedPublic
Actions

Authored by jhb on Jun 29 2018, 8:38 PM.

Details

Reviewers

kan
bapt
bdrewery

Commits

rP475290: Drop builtin float.h for amd64-gcc.

Summary

GCC's builtin <float.h> header is not compatible with
sys/x86/include/float.h. Drop the builtin header for now. If at
some point GCC's notion of floating point constants for i386 can
converge with sys/x86/include/float.h this can be restored.

Test Plan

built recent world and ran into build failure in lib32 libm after --sysroot fixes

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jun 29 2018, 8:38 PM

Herald added a subscriber: mat. · View Herald TranscriptJun 29 2018, 8:38 PM

Harbormaster completed remote builds in B17734: Diff 44663.Jun 29 2018, 8:38 PM

jhb mentioned this in D16228: Add ports for an i386 external GCC toolchain..Jul 11 2018, 4:36 PM

Rework to explicitly remove this header so that this is check-plist friendly.
Bump portrevision.

Harbormaster completed remote builds in B17988: Diff 45180.Jul 11 2018, 5:02 PM

jhb added reviewers: bapt, bdrewery.Jul 11 2018, 5:02 PM

cem added a subscriber: cem.Jul 13 2018, 11:48 PM

bapt accepted this revision.Jul 24 2018, 4:28 PM

This revision is now accepted and ready to land.Jul 24 2018, 4:28 PM

Closed by commit rP475290: Drop builtin float.h for amd64-gcc. (authored by jhb). · Explain WhyJul 25 2018, 12:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

devel/

amd64-gcc/

pkg-plist

1 line

powerpc64-gcc/

Makefile

6 lines

Diff 45814

View Options

head/devel/amd64-gcc/pkg-plist